[GitHub] zeppelin issue #1821: [ZEPPELIN-1875] permission dialog code is not stable

2017-01-02 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1821 Then will merge into master if there are no more comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1821: [ZEPPELIN-1875] permission dialog code is not stable

2017-01-02 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1821 Tested and LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #1821: [ZEPPELIN-1875] permission dialog code is not stable

2017-01-02 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1821 Tested this branch and checked the verbose forbidden error messages(my bad..) are totally gone when I turned off Shiro. Thanks @cloverhearts! LGTM 👍 --- If your project is set up for

[GitHub] zeppelin issue #1821: [ZEPPELIN-1875] permission dialog code is not stable

2016-12-31 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1821 @cloverhearts yup. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled