[GitHub] zeppelin issue #1830: ZEPPELIN-1867. Update document for pig interpreter and...

2017-01-10 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1830
  
Thanks! Merge into master if there are no more comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1830: ZEPPELIN-1867. Update document for pig interpreter and...

2017-01-10 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1830
  
Thanks @AhyoungRyu , I rename the note, please check the updated screenshot 
in PR description. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1830: ZEPPELIN-1867. Update document for pig interpreter and...

2017-01-10 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1830
  
Sorry for my late response. It looks nice! Except one minor suggestion, 
LGTM 👍 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1830: ZEPPELIN-1867. Update document for pig interpreter and...

2017-01-10 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1830
  
ping @AhyoungRyu , please check the updated screenshot 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1830: ZEPPELIN-1867. Update document for pig interpreter and...

2017-01-02 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1830
  
@zjffdu Nice! 

In the past `Spark Tutorial` is the only tutorial note in Zeppelin included 
by default. But after this PR, 5 tutorial notes will be shown to Zeppelin new 
commers. Since some ppl can try this Pig tutorial before Spark one, more 
detailed description will be helpful to users than just saying like below 
https://cloud.githubusercontent.com/assets/10060731/21586047/1c62f9a0-d10f-11e6-9a41-a368c07dd9ce.png;>


e.g. short description about Pig / you need to install `hadoop` before 
trying to run this tutorial note, and etc etc..  

There is good example ([Mahout tutorial 
note](https://github.com/apache/zeppelin/blob/master/notebook/2BYEZ5EVK/note.json#L4))
 you can refer to. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1830: ZEPPELIN-1867. Update document for pig interpreter and...

2017-01-01 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1830
  
@felixcheung @AhyoungRyu Please help review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---