Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1845
@prabhjyotsingh Yea I know you didn't change it. That's because it doesn't
have state before.
I agree that we can take care/discuss it in a different PR.
Thanks.
---
If your
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1845
Sorry for late response @prabhjyotsingh, @jongyoul .
Let me review soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1845
@astroshim do you have some cycle to review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1845
@astroshim Can you also review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1845
I don't think it make sense to have a fixed minimum table size. It should
also take into account the output row number. Anyway, we can improve it in a
followup ticket.
---
If your project is
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1845
Yes, that is our default minimum size of display table.
CI fails [#9847.5](https://travis-ci.org/apache/zeppelin/jobs/189775789);
which is not relevant to this. Will merge this if
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1845
LGTM, but I notice there's one large blank area before this exception. Is
it expected ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1845
@zjffdu How about this ? On error show output of previous successfully run
query.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1845
`What if one query fails ?`
There is no change in that. When it fails and doesn't continue.
Before:
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1845
@prabhjyotsingh What if one query fails ? Would it continue to run the
remaining queries or abort ? And since this is a new feature, we might better
to add document for it.
---
If your project
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1845
@zjffdu replaced regex with slightly better logic, let me know what you
think about this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user r-kamath commented on the issue:
https://github.com/apache/zeppelin/pull/1845
Tested. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
12 matches
Mail list logo
