[GitHub] zeppelin issue #1851: [ZEPPELIN-1908] Invalid Typo Method name

2017-01-06 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1851
  
Merge if there are no more comments on this 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1851: [ZEPPELIN-1908] Invalid Typo Method name

2017-01-05 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1851
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1851: [ZEPPELIN-1908] Invalid Typo Method name

2017-01-05 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1851
  
LGTM 
CI failed only in Selenium test and it looks irrelevant to this change
```
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 55.46 sec 
<<< FAILURE! - in org.apache.zeppelin.integration.InterpreterIT

testShowDescriptionOnInterpreterCreate(org.apache.zeppelin.integration.InterpreterIT)
  Time elapsed: 55.197 sec  <<< ERROR!
org.openqa.selenium.ElementNotVisibleException: Element is not currently 
visible and so may not be interacted with
```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1851: [ZEPPELIN-1908] Invalid Typo Method name

2017-01-05 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/1851
  
Looks good to me 👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---