[GitHub] zeppelin issue #1902: [ZEPPELIN-1821] Add HTTP client to elasticsearch inter...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1902 @jaspinderdineout This was merged into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1902: [ZEPPELIN-1821] Add HTTP client to elasticsearch inter...
Github user jaspinderdineout commented on the issue: https://github.com/apache/zeppelin/pull/1902 Why is this not merged into apache:master? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1902: [ZEPPELIN-1821] Add HTTP client to elasticsearch inter...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1902 CI failure looks unrelated, since it only removed commented-out code from last CI success. Thanks @bbonnin for great contribution. LGTM and merge to master if no further discussions! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1902: [ZEPPELIN-1821] Add HTTP client to elasticsearch inter...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1902 Works well as described. - tested on elasticsearch 2.4.4 (transport, http) and 5.0.0 (http only) - code looks nice. well abstracted client classes is shipped with some tests. there some commented code lines. LGTM except that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1902: [ZEPPELIN-1821] Add HTTP client to elasticsearch inter...
Github user jaspinderdineout commented on the issue: https://github.com/apache/zeppelin/pull/1902 When will this be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1902: [ZEPPELIN-1821] Add HTTP client to elasticsearch inter...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1902 LGTM @1ambda do you have any comment? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1902: [ZEPPELIN-1821] Add HTTP client to elasticsearch inter...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1902 @bbonnin ð @jongyoul I will take a look more deeply :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1902: [ZEPPELIN-1821] Add HTTP client to elasticsearch inter...
Github user bbonnin commented on the issue: https://github.com/apache/zeppelin/pull/1902 It looks better now, all is green ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1902: [ZEPPELIN-1821] Add HTTP client to elasticsearch inter...
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1902 @1ambda Can you review this PR deeply? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
