[GitHub] zeppelin issue #2085: [ZEPPELIN-1999] get interpreter property with replaced...

2017-03-23 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2085
  
Ok.

Any other comment? Merging if no more discussion.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2085: [ZEPPELIN-1999] get interpreter property with replaced...

2017-03-19 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/2085
  
@tinkoff-dwh Saw your latest update. As you did, 
```
## Usage
 For example in database exist user `user1` with some password and exists 
user with same name into Zeppelin. Configure the jdbc interpreter (postgres), 
set `default.user = #{user}`.

   1. Sign in (as `user1`)  
   2. Open interpreter  
   3. Execute `select current_user`
```

The above usage example can be added [JDBC interpreter 
docs](https://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/interpreter/jdbc.html). 
But it's okay we can update it in later time not in this PR. LGTM 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2085: [ZEPPELIN-1999] get interpreter property with replaced...

2017-03-18 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2085
  
Thanks @tinkoff-dwh for useful new feature.
LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2085: [ZEPPELIN-1999] get interpreter property with replaced...

2017-03-15 Thread dwhsys
Github user dwhsys commented on the issue:

https://github.com/apache/zeppelin/pull/2085
  
I think that this PR is a great step forward to enterprise version of 
Zeppelin. Using this feature there will be an ability to implement native 
integration between different interpreters based on single schema per user / 
note in core analytical DBMS. Another feature is the possibility of data access 
control without using credentials.

@felixcheung, @Leemoonsoo, what do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2085: [ZEPPELIN-1999] get interpreter property with replaced...

2017-03-12 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2085
  
I think this is a good feature to have. Let's hold on to get a bit more 
feedback on this - @Leemoonsoo what do you think about something like this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2085: [ZEPPELIN-1999] get interpreter property with replaced...

2017-03-09 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2085
  
@felixcheung
 Are there problems for merge?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2085: [ZEPPELIN-1999] get interpreter property with replaced...

2017-03-05 Thread mgarmash
Github user mgarmash commented on the issue:

https://github.com/apache/zeppelin/pull/2085
  
Nice feature! +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2085: [ZEPPELIN-1999] get interpreter property with replaced...

2017-03-02 Thread andrykrp
Github user andrykrp commented on the issue:

https://github.com/apache/zeppelin/pull/2085
  
Looks good


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2085: [ZEPPELIN-1999] get interpreter property with replaced...

2017-03-01 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2085
  
1. uniqueness of the marker to replace
2. similar format of the parameters in the note (${}, not the same, not to 
be confused)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---