[GitHub] zeppelin issue #2197: ZEPPELIN-2324. Add property zeppelin.spark.unSupported...

2017-03-29 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2197
  
> perhaps it should be changed in 
sparkInterpreter.getSparkVersion().isSupportedVersion() instead

I thought about it, but feel it is not proper to create a new member field 
in class SparkVersion as this is a interpreter level property, even it is not 
proper to me to create a static field in SparkVersion. So in the new PR, I 
create a new method `isUnSupportedSparkVersion` in `SparkInterpreter` to wrap 
all the logic. 

> Can you add testcase for this conf?
I didn't find an easy way for this test. So just manually verified it. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2197: ZEPPELIN-2324. Add property zeppelin.spark.unSupported...

2017-03-28 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2197
  
@Leemoonsoo @jongyoul  @felixcheung Please help review. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---