[GitHub] zeppelin issue #2216: [ZEPPELIN-2336] Fix note reload on another note create...

2017-04-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2216
  
Merge to master and branch-0.7 as a hotfix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2216: [ZEPPELIN-2336] Fix note reload on another note create...

2017-04-04 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2216
  
CI is green. i linked some of related issue in 
[ZEPPELIN-2336](https://issues.apache.org/jira/browse/ZEPPELIN-2336)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2216: [ZEPPELIN-2336] Fix note reload on another note create...

2017-04-04 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2216
  
@Leemoonsoo i found some js tests failing in second profile, let me take a 
look


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2216: [ZEPPELIN-2336] Fix note reload on another note create...

2017-04-04 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2216
  
@Leemoonsoo actually I couldn't reproduce ZEPPELIN-1145, but we can reopen 
it to make sure. maybe also /cc @r-kamath as original author


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2216: [ZEPPELIN-2336] Fix note reload on another note create...

2017-04-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2216
  
LGTM

I think ZEPPELIN-2336 is quite serious issue.
Once CI becomes, let's merge this PR asap to master and branch-0.7 as a 
hotfix, and reopen ZEPPELIN-1145 for further investigation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2216: [ZEPPELIN-2336] Fix note reload on another note create...

2017-04-03 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2216
  
@khalidhuseynov last commit in the master branch does not have test failure 
on second profile. Could you rebase and see if second profile passes?

Also this PR restores changes made in 
https://issues.apache.org/jira/browse/ZEPPELIN-1145. Should we reopen 
ZEPPELIN-1145 ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2216: [ZEPPELIN-2336] Fix note reload on another note create...

2017-04-03 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2216
  
second profile keeps failing 
[here](https://travis-ci.org/khalidhuseynov/zeppelin/jobs/217983115). as i 
tried locally, getting following error 
```
[ERROR] Failed to execute goal on project zeppelin-spark_2.10: Could not 
resolve dependencies for project 
org.apache.zeppelin:zeppelin-spark_2.10:jar:0.8.0-SNAPSHOT: Could not find 
artifact org.apache.zeppelin:zeppelin-display_2.11:jar:0.8.0-SNAPSHOT in 
apache.snapshots (http://repository.apache.org/snapshots) -> [Help 1]
```
and as i checked in 
https://repository.apache.org/content/groups/snapshots/org/apache/zeppelin/zeppelin-display_2.11/,
 indeed there's no `0.8.0-SNAPSHOT`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---