[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2326 Hi @vipul1409 , Could you check https://github.com/apache/zeppelin/pull/2505? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

Github user vipul1409 commented on the issue: https://github.com/apache/zeppelin/pull/2326 Hi Kun, Raised this PR for the fix. https://github.com/apache/zeppelin/pull/2392/files Regards, On Thu, Jun 1, 2017 at 9:11 PM, Kun

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2326 Hi @vipul1409, This PR occurs an error like ```js TypeError: Cannot read property 'create' of undefined at Object.link (http://localhost:9001/app.bundle.js:9662:52) at

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2326 Thanks @vipul1409 for great contribution. Thanks @1ambda for the review. Merge to master if no further discussions. --- If your project is set up for it, you can reply to this

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2326 Tested and works well (both in frontend, backend angular APIs). LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

Github user vipul1409 commented on the issue: https://github.com/apache/zeppelin/pull/2326 Fixed all the issues and the tests have also passed. Please let me know if any more details are needed. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2326 Your travis job failed at ``` Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 125.713 sec - in org.apache.zeppelin.integration.AuthenticationIT Results :

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2326 You can close and reopen this PR to trigger jenkins again (not travis). I will test and comment soon. Thanks for update. --- If your project is set up for it, you can reply to this email

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

Github user vipul1409 commented on the issue: https://github.com/apache/zeppelin/pull/2326 Sorry for delayed response. Rerun of failed job passed. I have also addressed all the PR comments. Let me know if anything more is needed. --- If your project is set up for it, you can

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

Github user vipul1409 commented on the issue: https://github.com/apache/zeppelin/pull/2326 Even latest master is breaking with exactly same error. I am not able to figure out the issue. Any help or suggestions will be great. --- If your project is set up for it, you can reply to

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

Github user vipul1409 commented on the issue: https://github.com/apache/zeppelin/pull/2326 Addressed review comments and moved the dependency to npm. One jenkins job is failing but looks unrelated to my changes. I also see build is marked as failed in master, just double checking if

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

Github user vipul1409 commented on the issue: https://github.com/apache/zeppelin/pull/2326 I checked Jenkins Job. The sub job failing is https://travis-ci.org/vipul1409/zeppelin/jobs/230634157 It is failing because of some git access issues. Any suggestions on what could be the

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

Github user vipul1409 commented on the issue: https://github.com/apache/zeppelin/pull/2326 Any suggestions on why jenkins job is failing? On checking in jenkins console output I don't see any smaller job failing. --- If your project is set up for it, you can reply to this email and

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2326 Oops. autocompletion didn't work. Sorry for confusing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

Github user vi commented on the issue: https://github.com/apache/zeppelin/pull/2326 Probably meant "Thanks for the contribution @vipul1409" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2326 Thanks for the contribution @vi 1. It is required to update `bin_license/LICENSE` when you want to add a new library. -