[GitHub] zeppelin issue #2346: [gh-pages] Hide pagination btn if there is only 1 page

2018-07-04 Thread jongyoul 
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/2346
  
@AhyoungRyu Can you please follow up this PR? If you don't want to proceed 
it now, can you close this PR?


---

[GitHub] zeppelin issue #2346: [gh-pages] Hide pagination btn if there is only 1 page

2017-05-16 Thread soralee 
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2346
  
Nicely Improvement it, Thanks @AhyoungRyu!
But, tested and I found a bug which if I moved a last page, the page 
buttons is disappeared so, I couldn't move to before pages. I attached the 
following screenshot.

[Before]

![before_page_number](https://cloud.githubusercontent.com/assets/8110458/26093280/2ac4887e-3a50-11e7-9fa8-a183f53c1ef2.gif)

[After]

![after_page_number](https://cloud.githubusercontent.com/assets/8110458/26093284/2f0728f6-3a50-11e7-866b-8ebbdd15834d.gif)

Could you confirm this problem?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2346: [gh-pages] Hide pagination btn if there is only 1 page

2017-05-15 Thread Leemoonsoo 
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2346
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2346: [gh-pages] Hide pagination btn if there is only 1 page

2017-05-15 Thread AhyoungRyu 
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/2346
  
`gh-pages` doesn't have CI check. So the red light is irrelevant with this 
change. 
Ready to review. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---