Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2347
Will merge this if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2347
Tried locally works fine.
@tinkoff-dwh can you resolve these conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2347
looks OK, let me test it out on my cluster, I'll update this thread.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2347
Ready to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2347
Tried the above:
With multiple queries;
https://cloud.githubusercontent.com/assets/674497/26358329/d46cf470-3fef-11e7-9afc-76e3bb448270.png;>
With single query;
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2347
if jdbc driver does not implement this method (getMoreResults), it will
work like you said will return the first result
---
If your project is set up for it, you can reply to this email and
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2347
Sure, I do see this working for Postgres as posted in the screenshot, do
you think this will work for rest of the data sources listed here
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2347
another solution, but I think it's better
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2347
Yes, correct.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2347
if all quieries is valid then the result will return from the first. is it
correct?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2347
IMO there should be a workaround if the logic fails.
And for handling error scenarios, here is what I think will happen.
Before recommendation:
![screen shot 2017-05-23 at
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2347
Which is fine, with the document there will be a workaround.
And the case that you are talking is true for Postgres, but for Hive if you
will try to execute multiple SQLs in one
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2347
single mode is default and the user will always get an incorrect result if
he writes multiple queries to in paragraph
---
If your project is set up for it, you can reply to this email and
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2347
Which I think is fine, because in that case, we will not try to use this
logic, and at least there will be a workaround if the user is facing any
problem because of this issue, and we can
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2347
@felixcheung @prabhjyotsingh
have a problem with single mode, if user execute multiple queries (all text
executes as single query) then result set is incorrect.
I think this
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2347
yes for interpreter settings
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2347
IMO property in settings of interpreter makes more sense, with a bit of a
documentation on how to enable/disable it.
cc: @felixcheung
---
If your project is set up for it, you can
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2347
@prabhjyotsingh
checkbox (for paragraph) which indicates to parse the request or not?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2347
Tested this on local, looks OK.
Can you also implement this comment
https://github.com/apache/zeppelin/pull/2347#issuecomment-302747859, i.e.
default to single query with a
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2347
@prabhjyotsingh
fixed problems
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2347
hmm, I see, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2347
@felixcheung +1 for defaulting to the single query.
And for all of your questions answer is yes.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2347
Perhaps multiple queries was the reason we tried to parse the text (we
really need to document these things better) - though I'm not sure how it would
work exactly? Do you get multiple table
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2347
Thanks, @zjffdu. @tinkoff-dwh will try to review this soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2347
This is for multiple line sql support, seems this is the only way.
@prabhjyotsingh has more context.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2347
\cc @prabhjyotsingh
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
26 matches
Mail list logo