Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2349
Tested and LGTM. Thanks @necosta for the improvement!
Merge to master if no further comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user necosta commented on the issue:
https://github.com/apache/zeppelin/pull/2349
ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user necosta commented on the issue:
https://github.com/apache/zeppelin/pull/2349
Hi @1ambda and @Leemoonsoo ,
Can you have another look at this one?
After rebasing latest master (now contains
[ZEPPELIN-2152](https://issues.apache.org/jira/browse/ZEPPELIN-2152)) and
Github user necosta commented on the issue:
https://github.com/apache/zeppelin/pull/2349
@1ambda ,
Renamed "zeppelin.helium.npm.registry" to
"zeppelin.helium.npm.installer.url"
I understand there is no need to update file "upgrade.md" as the change in
conf value is inside the
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2349
If we have both, then it's better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user necosta commented on the issue:
https://github.com/apache/zeppelin/pull/2349
Thanks @1ambda,
Allow me to disagree :) In my opinion should be: "I hope we have a proxy
option as well as configurations for those URLs"
The advantage of having configurable URLs is that
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2349
Personally, I hope we have a proxy option instead of configurations for
those URLs.
That's because, it's hard to configure every URLs for users. (not scalable
solution) There might be more
Github user necosta commented on the issue:
https://github.com/apache/zeppelin/pull/2349
@1ambda, latest updates:
- Renamed "registry" to "installer.url" as suggested in your comment
- Fixed CI
- "ZEPPELIN-2214 is about setting proxy for Helium. But Actually, this PR
it
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2349
Yes, we can split. Then,
- Let's make CI green
- I left one comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user necosta commented on the issue:
https://github.com/apache/zeppelin/pull/2349
@1ambda , thanks for the quick feedback :)
This ticket has related ticket ZEPPELIN-2152 which has a recent comment
related to your question:
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2349
@necosta Thanks for quick updating!
I have one more question. **Is there a proxy option for npm packages? (not
npm itself)**
Since if we an enable helium package, it will download
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2349
@necosta
What is your fork name? It should be `zeppelin`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user necosta commented on the issue:
https://github.com/apache/zeppelin/pull/2349
Travis is happy, Jenkins is unhappy. Anyone knows why?
```
python ./travis_check.py
Traceback (most recent call last):
File "./travis_check.py", line 35, in
author =
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2349
Since npm registry name can be changed arbitrarily it's worth to add a
configuration key for the hard-coded `"/npm/-/"`
---
If your project is set up for it, you can reply to this email and
14 matches
Mail list logo
