[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2018-09-18 Thread ajaygk95
Github user ajaygk95 commented on the issue: https://github.com/apache/zeppelin/pull/2373 > > > @SarunasG @1ambda @khalidhuseynov @andreaTP Hello, is there any doc of details for me to add libs in 0.7.3 and by changing the shiro.ini config file to support open id?

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2018-09-08 Thread ajaygk95
Github user ajaygk95 commented on the issue: https://github.com/apache/zeppelin/pull/2373 Hello, Has anyone tried with zeppelin with keycloak ? ---

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2018-06-19 Thread xixikaikai
Github user xixikaikai commented on the issue: https://github.com/apache/zeppelin/pull/2373 @SarunasG @1ambda @khalidhuseynov @andreaTP Hello, is there any doc of details for me to add libs in 0.7.3 and by changing the shiro.ini config file to support open id? ---

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2018-06-19 Thread xixikaikai
Github user xixikaikai commented on the issue: https://github.com/apache/zeppelin/pull/2373 ![image](https://user-images.githubusercontent.com/10403433/41584171-293fca40-73d9-11e8-8cfe-9ed2498f7078.png) ---

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2018-06-19 Thread xixikaikai
Github user xixikaikai commented on the issue: https://github.com/apache/zeppelin/pull/2373 `Zeppelin is restarting ZEPPELIN_CLASSPATH:

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2018-06-19 Thread xixikaikai
Github user xixikaikai commented on the issue: https://github.com/apache/zeppelin/pull/2373 Again I've added more jars to zeppelin-0.7.3, but the error occur once more

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2018-06-19 Thread xixikaikai
Github user xixikaikai commented on the issue: https://github.com/apache/zeppelin/pull/2373 ![image](https://user-images.githubusercontent.com/10403433/41582143-59948d4e-73d3-11e8-9a92-b853704b1575.png) ---

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2018-06-19 Thread xixikaikai
Github user xixikaikai commented on the issue: https://github.com/apache/zeppelin/pull/2373 hello I've put the following libs into my 0.7.3's zeppelin lib folder, But the errors occur, can I ask you for a help?

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2018-06-19 Thread xixikaikai
Github user xixikaikai commented on the issue: https://github.com/apache/zeppelin/pull/2373 `$ cat logs/zeppelin-zhengkai-zhengkais-MacBook-Pro.local.out ZEPPELIN_CLASSPATH:

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2018-06-19 Thread andreaTP
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2373 @xixikaikai sure, we are using keycloak in production ---

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2018-06-18 Thread xixikaikai
Github user xixikaikai commented on the issue: https://github.com/apache/zeppelin/pull/2373 BTW can I use local keycloak for oidc connect to zeppelin? I now set up a local env of keycloak @andreaTP ---

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2018-06-18 Thread xixikaikai
Github user xixikaikai commented on the issue: https://github.com/apache/zeppelin/pull/2373 @andreaTP thanks, I am now trying keycloak with the oidc ---

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2018-06-14 Thread andreaTP
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2373 actually a more detailed description is available here: https://github.com/apache/zeppelin/pull/2552/files ---

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2018-06-14 Thread andreaTP
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2373 I think the link is broken. here: https://github.com/apache/zeppelin/pull/2373/files ---

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2018-06-14 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2373 @xixikaikai https://github.com/apache/zeppelin/pull/2373#issuecomment-323267967 ---

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2018-06-13 Thread xixikaikai
Github user xixikaikai commented on the issue: https://github.com/apache/zeppelin/pull/2373 Is there any document or example to tell us how to use SSO function in zeppelin? ---

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2018-06-13 Thread xixikaikai
Github user xixikaikai commented on the issue: https://github.com/apache/zeppelin/pull/2373 @1ambda Do you have a sample code to test this function? ---

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2017-08-18 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2373 Hi! Please redirect your questions to dev@zeppelin.apache.org or open a JIRA if there is a bug? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2017-08-16 Thread andreaTP
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2373 Hi @SarunasG , actually I'm facing the very same situation here ... I haven't had enough time to dig deeper, but it looks like that 'logout` action is not triggering the REST call to do a

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2017-08-15 Thread SarunasG
Github user SarunasG commented on the issue: https://github.com/apache/zeppelin/pull/2373 Hi All, Have one more question related to OIDC enablement on Zeppelin. I am now able successfully authenticate my user and log into Zeppelin app by Shiro, OIDC and Keycloak, but

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2017-08-08 Thread SarunasG
Github user SarunasG commented on the issue: https://github.com/apache/zeppelin/pull/2373 Hi @andreaTP Having this line `/** = oidcSecurityFilter` in [urls] section fixed everything, now it works totally fine! Thank You very much for such a quick response and all the help

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2017-08-08 Thread andreaTP
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2373 Hi @SarunasG , yes I'm using Zeppelin with Keycloak from what I can see the only missing bit in your configuration is: ``` /** = oidcSecurityFilter ``` --- If your project is set up

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2017-08-07 Thread SarunasG
Github user SarunasG commented on the issue: https://github.com/apache/zeppelin/pull/2373 Hi @andreaTP, All, Could anyone please help me to understand this pull request better ? If I integrate all the changes as per this pull request and amend the shiro.ini file with OIDC

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2017-07-05 Thread andreaTP
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2373 I think this issue is addressed https://github.com/apache/zeppelin/pull/2463 I'm not sure if having a switch for prod and dev is good BTW --- If your project is set up for it, you can

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2017-07-04 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2373 @andreaTP After this PR, an error is thrown like in dev mode. To reproduce, - `cd zeppelin-web` - `npm install` (only once) - `npm run dev` Could you check it?

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2017-06-28 Thread andreaTP
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2373 thanks a lot! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2017-06-27 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2373 thanks merging if no more comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2017-06-27 Thread andreaTP
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2373 ok, now also CI is happy :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2017-06-26 Thread andreaTP
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2373 @Leemoonsoo @felixcheung @1ambda I have had to rebase on master again after a week of no updates. Please tell me what to do to on this to get it merged or why this is not going to be

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2017-06-23 Thread necosta
Github user necosta commented on the issue: https://github.com/apache/zeppelin/pull/2373 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2017-06-19 Thread necosta
Github user necosta commented on the issue: https://github.com/apache/zeppelin/pull/2373 @andreaTP , sorry, I forgot to add. You need to test on top of latest master. nokia:keycloak is 45 commits behind apache:master . That could explain why it's not failing here. Thanks. --- If

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2017-06-19 Thread andreaTP
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2373 @necosta checked again but it works for me and on CI ... I have had this problem once try to fetch and pull and see if this solves --- If your project is set up for it, you can reply to this

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2017-06-19 Thread necosta
Github user necosta commented on the issue: https://github.com/apache/zeppelin/pull/2373 @andreaTP , a bit strange why Jenkins succeeds, running "mvn clean package -DskipTests" fails with the below errors introduced in this pull request. Can you have a look? Thanks. >

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2017-06-14 Thread volumeint
Github user volumeint commented on the issue: https://github.com/apache/zeppelin/pull/2373 I just submitted a [pull request to buji-pac4j](https://github.com/bujiio/buji-pac4j/pull/62) to make the value of Principal.getName() configurable via shiro.ini. We just have to wait for it

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2017-06-12 Thread andreaTP
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2373 I sincerely think that this implementation is enough to unlock the usage of pac4j, buji (due to the rest of updates sent there). I think that the name parsing can be refactored later on,

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2017-06-09 Thread volumeint
Github user volumeint commented on the issue: https://github.com/apache/zeppelin/pull/2373 It turns out that the Pac4JPrincipal provided by buji is returning CommonProfile.getId() and not the getUsername() or getDisplayName() values for getName().

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2017-06-06 Thread andreaTP
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2373 do this minimal and cleaned up version needs anything else to be worked out in order to be merged? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2017-06-02 Thread andreaTP
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2373 @1ambda To be honest I'm not such an expert and I'm just integrating from a technical POV a solution that other experts in team found. I will love to have such documentation too, but I

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2017-06-01 Thread andreaTP
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2373 @1ambda potentially yes @khalidhuseynov thanks for pointing out a public server I can test! I will go through later on B.t.w. I realized that the MVP to get this working is just

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2017-06-01 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2373 Hi, I have a question. Does this PR means, zeppelin can be OAuth client? For example github, google, ... --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2017-06-01 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/2373 i've just tried to login using the config info from online demo for oidc-client in https://demo.c2id.com/oidc-client using modified config below ``` oidcConfig =