Github user necosta commented on the issue:
https://github.com/apache/zeppelin/pull/2398
Thanks guys!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2398
Merging if there's no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user necosta commented on the issue:
https://github.com/apache/zeppelin/pull/2398
Ready for another look. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user necosta commented on the issue:
https://github.com/apache/zeppelin/pull/2398
Thanks for the feedback @Leemoonsoo. Yes, I was 50-50 on having a new API
or reusing the "version" one. I'll go with your suggestion and refactor this
later this week. Thanks!
---
If your
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2398
Thanks @necosta for very useful improvement.
It's not a strong opinion, but how about make `api/version` return version
and git hash instead of add new api endpoint `api/git`? I think
