[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

2017-08-27 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2474 I will merge it if no more comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

2017-08-24 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2474 ping Leemoonsoo @1ambda @felixcheung @prabhjyotsingh for review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

2017-08-19 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2474 @Leemoonsoo I have fixed the issue, could you try it again ? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

2017-08-08 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2474 Tried last commit. I installed jupyter, IPython, ipykernel, grpcio in my conda environment and i configured my python interpreter like

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

2017-08-03 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2474 @Leemoonsoo @1ambda @felixcheung @prabhjyotsingh I made several follow up commit. All the features in this stage is done. Please help review that. I believe it would be a big improvement for

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

2017-07-31 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2474 Push another commit to support streaming output --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

2017-07-30 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2474 Push another commit to use IPython in PySparkInterpreter if IPython is available , otherwise fallback to the old implementation. --- If your project is set up for it, you can reply to this email

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

2017-07-27 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2474 Just push another commit to use IPythonInterpreter first, if it is not available, I will fallback it to the old PythonInterpreter. --- If your project is set up for it, you can reply to this

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

2017-07-16 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2474 @1ambda I did some investtigation on that, and puts some links in https://issues.apache.org/jira/browse/ZEPPELIN-2756, hope it would be helpful for you. --- If your project is set up for it, you

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

2017-07-16 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2474 Let create a PR to fix the ASCII issue, we can test this PR based on the ASCII PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

2017-07-16 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2474 Thanks @Leemoonsoo for catching that. This is due to I miss cursor for code completion. Just pushed another commit to fix that and add more unit test for it. ``` // there's no

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

2017-07-16 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2474 Is it expected completion list? ![image](https://user-images.githubusercontent.com/1540981/28252185-32d695a8-6ac9-11e7-9f29-2257700990d0.png) --- If your project is set up for it, you

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

2017-07-16 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2474 Yes, that works. It is covered in unit test (https://github.com/apache/zeppelin/pull/2474/files#diff-d9c8252d37a199d13b7157e88041c0e9R124). Also I manually verified it --- If your project is

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

2017-07-16 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2474 Tested 88a1f2f and ZeppelinContext works well. Does auto completion supposed to work? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

2017-07-13 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2474 @Leemoonsoo Regarding the ZeppelinContext, could you try that again ? It is covered in unit test, so should be able to work. I force committed it yesterday, the latest commit Id is

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

2017-07-13 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2474 Thanks for testing @Leemoonsoo . These special characters are for font color, create ZEPPELIN-2756 for that which might need help from @1ambda --- If your project is set up for it, you can reply

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

2017-07-11 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2474 @Leemoonsoo @1ambda @felixcheung @prabhjyotsingh Please help review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your