[GitHub] zeppelin issue #2687: [ZEPPELIN-3077] Cron scheduler is easy to get stuck wh...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2687 Thanks @kjmrknsn. Merge to master if no further review! ---
[GitHub] zeppelin issue #2687: [ZEPPELIN-3077] Cron scheduler is easy to get stuck wh...
Github user kjmrknsn commented on the issue: https://github.com/apache/zeppelin/pull/2687 Travis CI turned to green by merging https://github.com/apache/zeppelin/pull/2703 to my branch: https://travis-ci.org/kjmrknsn/zeppelin/builds/315898589 I would be glad if this PR would be merged. ---
[GitHub] zeppelin issue #2687: [ZEPPELIN-3077] Cron scheduler is easy to get stuck wh...
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2687 Ah yes ;) ---
[GitHub] zeppelin issue #2687: [ZEPPELIN-3077] Cron scheduler is easy to get stuck wh...
Github user kjmrknsn commented on the issue: https://github.com/apache/zeppelin/pull/2687 @felixcheung Thanks for your reviewing. > to be explicitly, let's add manually -> manually by an user opening this notebook I fixed it. (I used a correct phrase of `a user`.) Thanks. ---
[GitHub] zeppelin issue #2687: [ZEPPELIN-3077] Cron scheduler is easy to get stuck wh...
Github user kjmrknsn commented on the issue: https://github.com/apache/zeppelin/pull/2687 I'd be glad if any committers would review this PR. ---
[GitHub] zeppelin issue #2687: [ZEPPELIN-3077] Cron scheduler is easy to get stuck wh...
Github user kjmrknsn commented on the issue: https://github.com/apache/zeppelin/pull/2687 @felixcheung I added the documentation page `docs/usage/other_features/cron_scheduler.md` to this PR. I also added the explanation about this documentation to the `Questions:` section of the top comment of this PR. Thanks. ---
[GitHub] zeppelin issue #2687: [ZEPPELIN-3077] Cron scheduler is easy to get stuck wh...
Github user kjmrknsn commented on the issue:
https://github.com/apache/zeppelin/pull/2687
`logger.info("execution ... ");` has been changed to
`logger.warn("execution ... ");`. Thanks.
---
[GitHub] zeppelin issue #2687: [ZEPPELIN-3077] Cron scheduler is easy to get stuck wh...
Github user kjmrknsn commented on the issue: https://github.com/apache/zeppelin/pull/2687 @felixcheung > so if someone has a lot of notebook scheduled and running (from such schedule) at the same time, would it also cause quartz to run out of thread? Yes, but I think jobs are queued and they will be executed when one of the quartz threads finish the current job. Zeppelin administrators can change the number of the quartz threads whose default value is 10 by deploying the [quartz.properties](https://github.com/quartz-scheduler/quartz/blob/master/quartz-core/src/main/resources/org/quartz/quartz.properties) file on the Zeppelin classpath. ---
[GitHub] zeppelin issue #2687: [ZEPPELIN-3077] Cron scheduler is easy to get stuck wh...
Github user kjmrknsn commented on the issue: https://github.com/apache/zeppelin/pull/2687 All of the CI tests were passed: https://travis-ci.org/kjmrknsn/zeppelin/builds/308212514 ---
[GitHub] zeppelin issue #2687: [ZEPPELIN-3077] Cron scheduler is easy to get stuck wh...
Github user kjmrknsn commented on the issue: https://github.com/apache/zeppelin/pull/2687 @Leemoonsoo Thanks for your checking and suggestion. I added a test case to `NotebookTest.java`. ---
[GitHub] zeppelin issue #2687: [ZEPPELIN-3077] Cron scheduler is easy to get stuck wh...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2687 Thanks @kjmrknsn for taking care of this problem. LGTM. If there's a unit around [here](https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NotebookTest.java#L332) and make sure cron execution skip on paragraph run|pending, it would be even greater. ---
