Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2757
Thanks for the review will merge this if no more discussion.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2757
LGTM
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2757
Shall I merge this, if no more discussion?
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2757
@zjffdu have made the suggested changes, waiting for CI, does this looks
good?
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2757
It sounds a little redundant to ask user to both implement these version
related method and `isRevisionSupported`. How about creating a sub-interface of
`NotebookRepo` which support version
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2757
@felixcheung @zjffdu can you please help review this?
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2757
Yes, I believe that is exactly what I'm trying to do over here, for example
in S3NotebookRepo, since none of checkpoint, get, revisionHistory, or
setNoteRevision is implemented
Github user jhonderson commented on the issue:
https://github.com/apache/zeppelin/pull/2757
The methods for the versioning of the notes are defined at interface level
in NotebookRepo.java:
- Revision checkpoint(String noteId, String checkpointMsg,
AuthenticationInfo)
-
