Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2763
Thank you. Marked ZEPPELIN-3194 as resolved.
---
Github user masyan commented on the issue:
https://github.com/apache/zeppelin/pull/2763
@Leemoonsoo
https://issues.apache.org/jira/secure/ViewProfile.jspa?name=masyan
---
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2763
@masyan Do you have your JIRA id?
---
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2763
Thanks @masyan for great contribution. Looks good to me.
I'll merge this to master and branch-0.8 if no further comments.
---
Github user masyan commented on the issue:
https://github.com/apache/zeppelin/pull/2763
@Leemoonsoo
I fixed the parser. CI red because of unrelated code. Ready to merge
---
Github user masyan commented on the issue:
https://github.com/apache/zeppelin/pull/2763
@Leemoonsoo
found bug of parser
---
Github user masyan commented on the issue:
https://github.com/apache/zeppelin/pull/2763
CI green https://travis-ci.org/masyan/zeppelin/builds/342323724
---
Github user masyan commented on the issue:
https://github.com/apache/zeppelin/pull/2763
@Leemoonsoo
okay, I had one question in support of SAP, but they don't answer
---
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2763
I'd like to merge this PR to master if we have no further reviews. @masyan
Is this PR closed on purpose?
---
Github user masyan commented on the issue:
https://github.com/apache/zeppelin/pull/2763
need to specify the format of the "Combined filters (and/or)"
---
Github user masyan commented on the issue:
https://github.com/apache/zeppelin/pull/2763
@Leemoonsoo @felixcheung @zjffdu
if no more questions maybe merge it?
---
Github user masyan commented on the issue:
https://github.com/apache/zeppelin/pull/2763
@zjffdu @felixcheung
do you have any other questions?
---
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2763
Cool! Looks great to me.
---
Github user masyan commented on the issue:
https://github.com/apache/zeppelin/pull/2763
Ready to review
---
Github user masyan commented on the issue:
https://github.com/apache/zeppelin/pull/2763
@felixcheung
there are unit tests for convert queries (from Zeppelin format to SAP
format) and unit tests for auto completeion.
---
15 matches
Mail list logo
