Github user shahsank3t commented on the issue:
https://github.com/apache/zeppelin/pull/3019
@r-kamath - addressed your review comments. Please have a look again.
Thanks in advance.
---
Github user shahsank3t commented on the issue:
https://github.com/apache/zeppelin/pull/3019
@zjffdu Thanks for the review, I wasn't aware of Zeppelin context as
another thing. Have addressed your comments and fixed the wording.
---
Github user shahsank3t commented on the issue:
https://github.com/apache/zeppelin/pull/3019
@prabhjyotsingh Done enabling CI
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3019
@shahsank3t can you enable CI, looks like Travis builds are not enabled
https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
---
Github user shahsank3t commented on the issue:
https://github.com/apache/zeppelin/pull/3019
@jongyoul @zjffdu @prabhjyotsingh
Updated the code by reusing modal and other available methods. Please
review it.
---
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3019
I agree with @zjffdu. AFAIK, we already have a modal for some other
reasons. Can we reuse them for this issue?
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3019
I just have concern that is it possible to implement it via less code
change. Because it seems to be a very simple function to pop an iframe window.
Not sure why it would involve so many code
Github user shahsank3t commented on the issue:
https://github.com/apache/zeppelin/pull/3019
@zjffdu @felixcheung
Integrated your suggestions.
Below screenshot when single job is running:
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3019
Make sense for me to provide options to allow use to chose.
---
Github user shahsank3t commented on the issue:
https://github.com/apache/zeppelin/pull/3019
>can we open a pop up with options, like clicking on a url link in google
doc?
possible options: open, open in new tab
@zjffdu Above suggestion makes sense right? User can click
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/3019
can we open a pop up with options, like clicking on a url link in google
doc?
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3019
One drawback of inline UI is that user can not switch from spark ui and
notebook, this may make user annoyed .
---
Github user shahsank3t commented on the issue:
https://github.com/apache/zeppelin/pull/3019
@zjffdu Apologies missed out the earlier notification.
> I didn't try this PR, but I didn't see backend pass
spark.ui.allowFramingFrom to frontend, so how does frontend know whether
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3019
ping @shahsank3t Any updates ?
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3019
@shahsank3t I didn't try this PR, but I didn't see backend pass
`spark.ui.allowFramingFrom` to frontend, so how does frontend know whether it
should show spark ui inline or in another windows of
Github user shahsank3t commented on the issue:
https://github.com/apache/zeppelin/pull/3019
@prabhjyotsingh @r-kamath - Just a reminder to review this.
---
16 matches
Mail list logo
