[GitHub] zeppelin issue #3266: [ZEPPELIN-3914] upgrade Flink to 1.7.0

2018-12-19 Thread zjffdu 
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3266
  
LGTM


---

[GitHub] zeppelin issue #3266: [ZEPPELIN-3914] upgrade Flink to 1.7.0

2018-12-16 Thread zjffdu 
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3266
  
@xueyumusic Thanks for the contribution, we can make it as subtask of 
ZEPPELIN-3913. BTW I am curious to know whether you are using flink in zeppelin 
? If yes, could you share more details ? Because currently I am doing some 
improvement on flink interpreter and try to provide better user experience for 
flink users. 


---

[GitHub] zeppelin issue #3266: [ZEPPELIN-3914] upgrade Flink to 1.7.0

2018-12-16 Thread xueyumusic 
Github user xueyumusic commented on the issue:

https://github.com/apache/zeppelin/pull/3266
  
Hi, @liuxunorg , thanks for your point. I looked at ZEPPELIN-3913 and it 
mainly aims at streaming engine based on Flink.  I think it is better to use 
new version Flink (currently 1.7) as starting point  of streaming engine, and 
this PR is only for current batch engine and does not introduce extra 
functions, current tests could cover the modifications. So I think this PR and 
issue ZEPPELIN-3914 could be a subtask of  ZEPPELIN-3913 and does not conflicts 
with ZEPPELIN-3913.
What do you think ? @zjffdu 


---

[GitHub] zeppelin issue #3266: [ZEPPELIN-3914] upgrade Flink to 1.7.0

2018-12-16 Thread liuxunorg 
Github user liuxunorg commented on the issue:

https://github.com/apache/zeppelin/pull/3266
  
I saw @zjffdu  created [[Umbrella] Better support flink 
interpreter](https://issues.apache.org/jira/browse/ZEPPELIN-3913). It may not 
be a simple version upgrade, see if  @zjffdu has a complete upgrade plan for 
flink. :-)


---