[GitHub] zeppelin pull request #1254: [ZEPPELIN-1257] storage - fix get note revision...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1254


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1254: [ZEPPELIN-1257] storage - fix get note revision...

[khalidhuseynov]

GitHub user khalidhuseynov reopened a pull request:

https://github.com/apache/zeppelin/pull/1254

[ZEPPELIN-1257] storage - fix get note revision api

### What is this PR for?
Getting revision of note requires only unique revision id and the whole 
revision object isn't required. This PR is to fix the issue.


### What type of PR is it?
Bug Fix | Improvement

### Todos
* [x] - change storage api
* [x] - modify notebook server

### What is the Jira issue?
[ZEPPELIN-1257](https://issues.apache.org/jira/browse/ZEPPELIN-1257)

### How should this be tested?
Storage layer tests should pass, green CI

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/incubator-zeppelin 
fix/get-note-revision-api

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1254.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1254


commit 96490a29295221a2dbc8f8bac50b5f87cf9bb847
Author: Khalid Huseynov 
Date:   2016-07-31T07:15:08Z

change api Revision -> String (revision id)

commit 3b7868e254bfe338755ebf4a9de8a71ac49db8b8
Author: Khalid Huseynov 
Date:   2016-07-31T07:31:39Z

change Revision -> String in NotebookServer

commit 1bab6a4c9b3bbca958c540c6c6cfd4e012504270
Author: Khalid Huseynov 
Date:   2016-07-31T07:37:46Z

consistency check: NotebookRepo.Revision -> Revision

commit f14c15afb59da0e2c7bdab0cd443653276cdbbfc
Author: Khalid Huseynov 
Date:   2016-08-01T04:59:16Z

fix tests




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1254: [ZEPPELIN-1257] storage - fix get note revision...

[khalidhuseynov]

Github user khalidhuseynov closed the pull request at:

https://github.com/apache/zeppelin/pull/1254


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1254: [ZEPPELIN-1257] storage - fix get note revision...

[khalidhuseynov]

Github user khalidhuseynov closed the pull request at:

https://github.com/apache/zeppelin/pull/1254


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1254: [ZEPPELIN-1257] storage - fix get note revision...

[khalidhuseynov]

GitHub user khalidhuseynov reopened a pull request:

https://github.com/apache/zeppelin/pull/1254

[ZEPPELIN-1257] storage - fix get note revision api

### What is this PR for?
Getting revision of note requires only unique revision id and the whole 
revision object isn't required. This PR is to fix the issue.


### What type of PR is it?
Bug Fix | Improvement

### Todos
* [x] - change storage api
* [x] - modify notebook server

### What is the Jira issue?
[ZEPPELIN-1257](https://issues.apache.org/jira/browse/ZEPPELIN-1257)

### How should this be tested?
Storage layer tests should pass, green CI

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/incubator-zeppelin 
fix/get-note-revision-api

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1254.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1254


commit 96490a29295221a2dbc8f8bac50b5f87cf9bb847
Author: Khalid Huseynov 
Date:   2016-07-31T07:15:08Z

change api Revision -> String (revision id)

commit 3b7868e254bfe338755ebf4a9de8a71ac49db8b8
Author: Khalid Huseynov 
Date:   2016-07-31T07:31:39Z

change Revision -> String in NotebookServer

commit 1bab6a4c9b3bbca958c540c6c6cfd4e012504270
Author: Khalid Huseynov 
Date:   2016-07-31T07:37:46Z

consistency check: NotebookRepo.Revision -> Revision

commit f14c15afb59da0e2c7bdab0cd443653276cdbbfc
Author: Khalid Huseynov 
Date:   2016-08-01T04:59:16Z

fix tests




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1254: [ZEPPELIN-1257] storage - fix get note revision...

[khalidhuseynov]

GitHub user khalidhuseynov opened a pull request:

https://github.com/apache/zeppelin/pull/1254

[ZEPPELIN-1257] storage - fix get note revision api

### What is this PR for?
Getting revision of note requires only unique revision id and the whole 
revision object isn't required. This PR is to fix the issue.


### What type of PR is it?
Bug Fix | Improvement

### Todos
* [x] - change storage api
* [x] - modify notebook server

### What is the Jira issue?
[ZEPPELIN-1257](https://issues.apache.org/jira/browse/ZEPPELIN-1257)

### How should this be tested?
Storage layer tests should pass, green CI

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/incubator-zeppelin 
fix/get-note-revision-api

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1254.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1254


commit 96490a29295221a2dbc8f8bac50b5f87cf9bb847
Author: Khalid Huseynov 
Date:   2016-07-31T07:15:08Z

change api Revision -> String (revision id)

commit 3b7868e254bfe338755ebf4a9de8a71ac49db8b8
Author: Khalid Huseynov 
Date:   2016-07-31T07:31:39Z

change Revision -> String in NotebookServer

commit 1bab6a4c9b3bbca958c540c6c6cfd4e012504270
Author: Khalid Huseynov 
Date:   2016-07-31T07:37:46Z

consistency check: NotebookRepo.Revision -> Revision




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---