[GitHub] zeppelin pull request #1304: [ZEPPELIN-1190] [WIP] Visit Notebook Revision
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1304 ---
[GitHub] zeppelin pull request #1304: [ZEPPELIN-1190] [WIP] Visit Notebook Revision
GitHub user corneadoug reopened a pull request: https://github.com/apache/zeppelin/pull/1304 [ZEPPELIN-1190] [WIP] Visit Notebook Revision ### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check out the contributing guide - https://github.com/apache/zeppelin/blob/master/CONTRIBUTING.md ### What type of PR is it? To visit the Notebook Revision after selecting it from the dropdown ### Todos * [x] - API needs to be fixed to send Revision ID * [ ] - Render Revision * [ ] - Click on revision action * [ ] - Select the right revision in the dropdown ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1190 ### How should this be tested? No test yet ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No (until full feature is implemented) You can merge this pull request into a Git repository by running: $ git pull https://github.com/corneadoug/incubator-zeppelin feature/visitRevision Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1304.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1304 commit e5f28e938587601e78484e5a1eb239803b9c160a Author: Damien CORNEAUDate: 2016-07-29T06:23:18Z create new root and call revision commit 8d5d1f3275938258fb4a992221c93722185c Author: Damien CORNEAU Date: 2016-08-17T05:50:52Z Change call to websocketEvent --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1304: [ZEPPELIN-1190] [WIP] Visit Notebook Revision
Github user corneadoug closed the pull request at: https://github.com/apache/zeppelin/pull/1304 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1304: [ZEPPELIN-1190] [WIP] Visit Notebook Revision
GitHub user corneadoug opened a pull request: https://github.com/apache/zeppelin/pull/1304 [ZEPPELIN-1190] [WIP] Visit Notebook Revision ### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check out the contributing guide - https://github.com/apache/zeppelin/blob/master/CONTRIBUTING.md ### What type of PR is it? To visit the Notebook Revision after selecting it from the dropdown ### Todos * [ ] - API needs to be fixed to send Revision ID * [ ] - Render Revision * [ ] - Click on revision action * [ ] - Select the right revision in the dropdown ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1190 ### How should this be tested? No test yet ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No (until full feature is implemented) You can merge this pull request into a Git repository by running: $ git pull https://github.com/corneadoug/incubator-zeppelin feature/visitRevision Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1304.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1304 commit 8512381d5ee3f0ff7aee3a28fe78104aece243fc Author: Damien CORNEAUDate: 2016-07-29T06:23:18Z create new root and call revision --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---