[GitHub] zeppelin pull request #1308: [ZEPPELIN-1312] Hotfix - consistent getNoteRevi...

2016-08-09 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1308


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1308: [ZEPPELIN-1312] Hotfix - consistent getNoteRevi...

2016-08-09 Thread khalidhuseynov
GitHub user khalidhuseynov opened a pull request:

https://github.com/apache/zeppelin/pull/1308

[ZEPPELIN-1312] Hotfix - consistent getNoteRevision in websocket call

### What is this PR for?
This pr fixes inconsistency on websocket call of getNoteRevision method on 
frontend, since backend waits for `Revision` but front sends `RevisionId`.  
This is the simplest fix without api change.


### What type of PR is it?
Hot Fix

### Todos
* [ ] - `RevisionId` -> `Revision`

### What is the Jira issue?
[Zeppelin-1312](https://issues.apache.org/jira/browse/ZEPPELIN-1312)

### How should this be tested?
CI pass

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/incubator-zeppelin 
hotfix/zeppelin-1312

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1308.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1308


commit a14d71a53adb9c60c76ee7e5c5b82799cef86e9f
Author: Khalid Huseynov 
Date:   2016-08-09T08:06:09Z

make front consistent with backend: revisionId -> revision




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---