[GitHub] zeppelin pull request #1445: [Zeppelin-1001] Take care of comma/tab escape i...

2016-10-02 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1445


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1445: [Zeppelin-1001] Take care of comma/tab escape i...

2016-09-29 Thread meenakshisekar 
GitHub user meenakshisekar reopened a pull request:

https://github.com/apache/zeppelin/pull/1445

[Zeppelin-1001]  Take care of comma/tab escape in csv/tsv download

### What is this PR for?
When the data is downloaded as CSV/TSV, the comma/tab in the actual data 
has to be handled so that they come exactly as the same data when downloaded.

### What type of PR is it?
[Bug Fix]

### Todos
* [ ] - Task

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1001

### How should this be tested?
Modify the data to be loaded to have a comma.
Create a paragraph to pull up that data and display.
Now click on the download as CSV/TSV button in the tool bar.
Once the data is downloaded verify whether the original data is unaltered 
and the comma is escaped.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/meenakshisekar/zeppelin ZEPPELIN-1001

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1445.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1445


commit 73b1868dbf60d2ee1fb90bd0f168a64858d3593b
Author: meenakshisekar 
Date:   2016-09-19T11:16:12Z

Zeppelin-1001 Modified the data with comma/tab to be surronded by double 
quotes so that they are escaped.

commit 657dcbee8cc3aafc70c7f73378efc560e93afccd
Author: meenakshisekar 
Date:   2016-09-19T11:16:12Z

Zeppelin-1001 Modified the data with comma/tab to be surronded by double 
quotes so that they are escaped.

commit 2f7d78a74bc23507df89dd912e3d0b9e3a041980
Author: meenakshisekar 
Date:   2016-09-29T06:59:04Z

Altered the code as per PR suggestion 1465

commit ce27b826fa8636891fa9530e7d6cf929465e2c8b
Author: meenakshisekar 
Date:   2016-09-29T07:08:40Z

Changes committed as per review comments in PR

commit 5e14da8052cf00c025062637590347c256ca3f6d
Author: meenakshisekar 
Date:   2016-09-29T07:16:39Z

review comments fixed




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1445: [Zeppelin-1001] Take care of comma/tab escape i...

2016-09-29 Thread meenakshisekar 
Github user meenakshisekar closed the pull request at:

https://github.com/apache/zeppelin/pull/1445


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1445: [Zeppelin-1001] Take care of comma/tab escape i...

2016-09-28 Thread meenakshisekar 
GitHub user meenakshisekar reopened a pull request:

https://github.com/apache/zeppelin/pull/1445

[Zeppelin-1001]  Take care of comma/tab escape in csv/tsv download

### What is this PR for?
When the data is downloaded as CSV/TSV, the comma/tab in the actual data 
has to be handled so that they come exactly as the same data when downloaded.

### What type of PR is it?
[Bug Fix]

### Todos
* [ ] - Task

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1001

### How should this be tested?
Modify the data to be loaded to have a comma.
Create a paragraph to pull up that data and display.
Now click on the download as CSV/TSV button in the tool bar.
Once the data is downloaded verify whether the original data is unaltered 
and the comma is escaped.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/meenakshisekar/zeppelin ZEPPELIN-1001

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1445.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1445


commit 73b1868dbf60d2ee1fb90bd0f168a64858d3593b
Author: meenakshisekar 
Date:   2016-09-19T11:16:12Z

Zeppelin-1001 Modified the data with comma/tab to be surronded by double 
quotes so that they are escaped.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1445: [Zeppelin-1001] Take care of comma/tab escape i...

2016-09-28 Thread meenakshisekar 
Github user meenakshisekar closed the pull request at:

https://github.com/apache/zeppelin/pull/1445


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1445: [Zeppelin-1001] Take care of comma/tab escape i...

2016-09-28 Thread meenakshisekar 
Github user meenakshisekar closed the pull request at:

https://github.com/apache/zeppelin/pull/1445


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1445: [Zeppelin-1001] Take care of comma/tab escape i...

2016-09-28 Thread meenakshisekar 
GitHub user meenakshisekar reopened a pull request:

https://github.com/apache/zeppelin/pull/1445

[Zeppelin-1001]  Take care of comma/tab escape in csv/tsv download

### What is this PR for?
When the data is downloaded as CSV/TSV, the comma/tab in the actual data 
has to be handled so that they come exactly as the same data when downloaded.

### What type of PR is it?
[Bug Fix]

### Todos
* [ ] - Task

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1001

### How should this be tested?
Modify the data to be loaded to have a comma.
Create a paragraph to pull up that data and display.
Now click on the download as CSV/TSV button in the tool bar.
Once the data is downloaded verify whether the original data is unaltered 
and the comma is escaped.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/meenakshisekar/zeppelin ZEPPELIN-1001

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1445.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1445


commit 73b1868dbf60d2ee1fb90bd0f168a64858d3593b
Author: meenakshisekar 
Date:   2016-09-19T11:16:12Z

Zeppelin-1001 Modified the data with comma/tab to be surronded by double 
quotes so that they are escaped.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1445: [Zeppelin-1001] Take care of comma/tab escape i...

2016-09-27 Thread meenakshisekar 
GitHub user meenakshisekar reopened a pull request:

https://github.com/apache/zeppelin/pull/1445

[Zeppelin-1001]  Take care of comma/tab escape in csv/tsv download

### What is this PR for?
When the data is downloaded as CSV/TSV, the comma/tab in the actual data 
has to be handled so that they come exactly as the same data when downloaded.

### What type of PR is it?
[Bug Fix]

### Todos
* [ ] - Task

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1001

### How should this be tested?
Modify the data to be loaded to have a comma.
Create a paragraph to pull up that data and display.
Now click on the download as CSV/TSV button in the tool bar.
Once the data is downloaded verify whether the original data is unaltered 
and the comma is escaped.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/meenakshisekar/zeppelin ZEPPELIN-1001

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1445.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1445


commit 73b1868dbf60d2ee1fb90bd0f168a64858d3593b
Author: meenakshisekar 
Date:   2016-09-19T11:16:12Z

Zeppelin-1001 Modified the data with comma/tab to be surronded by double 
quotes so that they are escaped.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1445: [Zeppelin-1001] Take care of comma/tab escape i...

2016-09-27 Thread meenakshisekar 
Github user meenakshisekar closed the pull request at:

https://github.com/apache/zeppelin/pull/1445


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---