[GitHub] zeppelin pull request #1824: [ZEPPELIN-1850] Remove grunt-contrib-clean (gru...

2017-01-03 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1824


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1824: [ZEPPELIN-1850] Remove grunt-contrib-clean (gru...

2016-12-29 Thread 1ambda
GitHub user 1ambda opened a pull request:

https://github.com/apache/zeppelin/pull/1824

[ZEPPELIN-1850] Remove grunt-contrib-clean (grunt)

### What is this PR for?

Replaced `grunt-contrib-clean` to 
[rimraf](https://github.com/isaacs/rimraf) 

- to remove `Gruntfile.js`
- to have npm managed scripts in `package.json` while running `rm -rf` in 
multiple platforms including windows
- Also, fixed invalid `prestart` npm command to `predev`

This PR related to

- https://github.com/apache/zeppelin/pull/1812 (Using yarn)
- https://github.com/apache/zeppelin/pull/1818 (Removing jscs)

### What type of PR is it?

[Improvement]

### Todos

Done at once

### What is the Jira issue?

[ZEPPELIN-1850](https://issues.apache.org/jira/browse/ZEPPELIN-1850)

### How should this be tested?

- `npm run test`, `npm run build`, `npm run dev` should work

### Screenshots (if appropriate)

None

### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/1ambda/zeppelin 
ZEPPELIN-1850/remove-grunt-clean

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1824.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1824


commit 86fddb9e4263b39dccb0e959f5e46210be7e3516
Author: 1ambda <1am...@gmail.com>
Date:   2016-12-30T06:55:33Z

fix: Remove grunt-contrib-clean




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---