Re: Disable Flaky Test

2018-06-20 Thread Jongyoul Lee
Hi, I think it's good but we might need a plan when we enable them again. Basically, I agree with it. On Tue, Jun 19, 2018 at 1:49 AM, Jeff Zhang wrote: > Hi Folks, > > Seems there's no objection on this, so I assume everyone agree on it. I > have merged this PR. From now on, please double

Re: Disable Flaky Test

2018-06-19 Thread Jeff Zhang
Hi Folks, Seems there's no objection on this, so I assume everyone agree on it. I have merged this PR. From now on, please double check the travis status before you merge your PR if you are committer and make sure the travis build status before you ask others to review if you are not committer.

[GitHub] zeppelin pull request #3020: ZEPPELIN-3535. Disable flaky test

2018-06-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/3020 ---

[GitHub] zeppelin issue #3020: ZEPPELIN-3535. Disable flaky test

2018-06-16 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3020 Github fails to sync up with apache git, now it is synced. ---

Re: Disable Flaky Test

2018-06-14 Thread Jeff Zhang
BTW, please* add unit test for any new PR* unless it is very trivial change and other committer agree it is OK without unit test. If you find it is difficult to add unit test. There will be several reasons according my experience. 1. It is due to the architecture and evolution of zeppelin, as

Disable Flaky Test

2018-06-14 Thread Jeff Zhang
Hi Folks, The zeppelin travis become unstable again recently. I know it is really annoying and frustrated, so I create a PR to disable these flaky tests. There still some flaky test, but happens in low frequency. According my experience, if you still have travis build failure after this PR, you

[GitHub] zeppelin pull request #3020: ZEPPELIN-3535. Disable flaky test

2018-06-14 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/3020 ZEPPELIN-3535. Disable flaky test ### What is this PR for? This PR is trying to disable the flaky test of zeppelin that fails very frequently. ### What type of PR