[GitHub] incubator-zeppelin pull request: [ZEPPELIN-502] Python interpreter...

2016-05-21 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/869#issuecomment-220805293 This looks great, thanks, just a couple of minor comments. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-zeppelin pull request: Make zeppelin work with CDH5.7.0

2016-05-18 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/868#issuecomment-220216617 @secsubs unfortunately no, it seems to be a breaking API change in CDH-5.7 (also in Spark 2.0) Let's get Travis tests to pass and merge this

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-577] ASCII control char...

2016-05-18 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/894#issuecomment-220215547 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: merge:from apache-master(for zepp...

2016-05-17 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/893#issuecomment-219926200 did you open this by accident? please close this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-zeppelin pull request: Make zeppelin work with CDH5.7.0

2016-05-17 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/868#issuecomment-219814326 Thanks!  CDH is known to have an older Akka and normally we build with the profile -Pvendor-repo to get that to work

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-185] ZeppelinContext me...

2016-05-17 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/176#issuecomment-219712754 I don't think this is currently supported, looking at the code. The error is caused by py4j trying to convert the DataFrame type. Do you

[GitHub] incubator-zeppelin pull request: Make zeppelin work with CDH5.7.0

2016-05-17 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/868#issuecomment-219712068 Does the fix in this PR make it work for your case? --- If your project is set up for it, you can reply to this

[GitHub] incubator-zeppelin pull request: Make zeppelin work with CDH5.7.0

2016-05-16 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/868#issuecomment-219617814 I will try to look into the test error in a couple of days. @H4ml3t Not sure I understand - could you elaborate? --- If your project is set up for

[GitHub] incubator-zeppelin pull request: Missing upgrade link in docs from...

2016-05-13 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/885#issuecomment-219175866 merged. will roll this up to the next doc update. thanks. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-699] Return Paragraph e...

2016-05-13 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/746#issuecomment-219175679 hello - how are we on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: ZEPPELIN-773 : Livy interperter

2016-05-13 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/827#issuecomment-219175485 Please check out [this](https://github.com/apache/incubator-zeppelin/pull/827/files/cb65c866558d22467e74046440284df28016c733

[GitHub] incubator-zeppelin pull request: Resource pools api

2016-05-13 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/822#issuecomment-219174529 How are we on this? @Leemoonsoo would you like to take a look? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-zeppelin pull request: Make zeppelin work with CDH5.7.0

2016-05-13 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/868#issuecomment-219174262 @krisgeus thanks - it looks like tests are failing fairly consistently, but not clear what's going on. Would you have some time to take a look, o

[GitHub] incubator-zeppelin pull request: Make zeppelin work with CDH5.7.0

2016-05-12 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/868#issuecomment-218965240 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: Fix interpreter.sh classpath

2016-05-12 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/889#issuecomment-218909569 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: Make zeppelin work with CDH5.7.0

2016-05-12 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/868#issuecomment-218909358 Hi @krisgeus could you separate the change referenced in [here](https://github.com/apache/incubator-zeppelin/pull/868/files#r62711339) so we could merge

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-605][WIP] Add support f...

2016-05-12 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/747#issuecomment-218909086 @adeandrade this seems to be a breaking change in Spark 2.0, also being fixed in #868 --- If your project is set up for it, you can reply to this

[GitHub] incubator-zeppelin pull request: ZEPPELIN-849: Zeppelin Crashes in...

2016-05-11 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/887#issuecomment-218667991 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: Missing upgrade link in docs from...

2016-05-11 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/885#issuecomment-218667755 merging if no more commentLGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-845] Fix Image URL issu...

2016-05-11 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/882#issuecomment-218667209 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: Make zeppelin work with CDH5.7.0

2016-05-09 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/868#issuecomment-218026464 Sure - sounds like we should push this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-05-04 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-217005186 does this PR change the export to CSV capability? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-zeppelin pull request: ZEPPELIN-773 : Livy interperter

2016-05-03 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/827#issuecomment-216739676 cool, thanks, I guess only (this)[https://github.com/apache/incubator-zeppelin/pull/827#discussion_r61179320] and (this)[https://github.com/apache

[GitHub] incubator-zeppelin pull request: CI: debug flaky webapp build

2016-05-03 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/871#issuecomment-216738681 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: Fixing Zeppelin-838: Minor improv...

2016-05-03 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/872#issuecomment-216738630 The term "note" is in fact used in a few places to refer to a notebook. I don't have a preference either way so I'd leave other

[GitHub] incubator-zeppelin pull request: Make zeppelin work with CDH5.7.0

2016-05-03 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/868#issuecomment-216738516 Thanks for sorting this out and contributing a PR. Do you know if this change specific to CDH 5.7.0 is intentional - do you know if there's a JI

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-742] Add documentation ...

2016-04-28 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/865#issuecomment-215609009 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-779] Dynamic form doesn...

2016-04-28 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/864#issuecomment-215608571 I didn't know in python 3, map(list()) returns a map! http://stackoverflow.com/questions/1303347/getting-a-map-to-return-a-list-in-pytho

[GitHub] incubator-zeppelin pull request: Prevent duplicated response heade...

2016-04-28 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/863#issuecomment-215608311 LGTM. is there a way to test/check for this automatically? is there a way to prevent addCorsHeaders() getting call multiple times? --- If your

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-183] Interpreter proces...

2016-04-27 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/795#issuecomment-215226858 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-04-27 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-215225519 We would need export to file feature which seems like is not supported in the free Handsontable version? --- If your project is set up for it, you can

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-157] Adding Map Visuali...

2016-04-27 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/765#issuecomment-215224988 @Madhuka let us know if we could help! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-672] Add feature to exp...

2016-04-27 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/761#issuecomment-215126421 Could you check out #858? Seems to overlap with this PR https://github.com/apache/incubator-zeppelin/pull/858 --- If

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2016-04-27 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-215126055 Great - will you have time to get that ready then? _ --- If your project is set up

[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...

2016-04-27 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-214995913 Based on the earlier comment, are we moving to #728 then? --- If your project is set up for it, you can reply to

[GitHub] incubator-zeppelin pull request: ZEPPELIN-773 : Livy interperter

2016-04-26 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/827#issuecomment-214856244 Could you please add the doc to docs/_includes/themes/zeppelin/_navigation.html And any license changes? http

[GitHub] incubator-zeppelin pull request: add /r/lib/ in .gitignore

2016-04-26 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/857#issuecomment-214847334 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-04-26 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-214847192 How does this work with some of the pending data table changes? like #6, #714, #725, #761 --- If your project is set up for it, you can reply to

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-798] Migrate to Jetty v...

2016-04-26 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/831#issuecomment-214845739 LGTM merging if no more comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-zeppelin pull request: ZEPPELIN-824 - Make CI Crash when...

2016-04-25 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/854#issuecomment-214562891 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-823] Remove usage of Sc...

2016-04-25 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/853#issuecomment-214562735 LGTM merging if no more comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-zeppelin pull request: Use bootstrap dialog in place of ...

2016-04-23 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/837#issuecomment-213791755 My bad. Are you asking if this issue should have a JIRA to track this change? --- If your project is set up for it, you

[GitHub] incubator-zeppelin pull request: ZEPPELIN-818: Set appropriate def...

2016-04-22 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/849#issuecomment-213656654 Should this be a different JIRA then? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-zeppelin pull request: Fix typos in docs

2016-04-22 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/852#issuecomment-213656603 thanks for fixing all of those! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-799] Modify `index.html...

2016-04-22 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/851#issuecomment-213656545 right, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-209] Folder support for...

2016-04-21 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/796#issuecomment-213217821 any more comment, @zhongneu, @Leemoonsoo , @bzz? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-798] Migrate to Jetty v...

2016-04-21 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/831#issuecomment-213190438 +@bzz This seems like an issue with Maven build pulling down dependencies. Try close/reopen PR at a different time of the day when Travis is less

[GitHub] incubator-zeppelin pull request: Use bootstrap dialog in place of ...

2016-04-21 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/837#issuecomment-213186699 thx. any more comment? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-zeppelin pull request: ZEPPELIN-818: Set appropriate def...

2016-04-21 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/849#issuecomment-213174433 There is another PR on this same bug? https://github.com/apache/incubator-zeppelin/pull/846 --- If your project is set up for it, you can reply to

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-818]Permissions cannot ...

2016-04-21 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/846#issuecomment-213171499 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: ZEPPELIN-815 don't create a sub s...

2016-04-21 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/844#issuecomment-213170425 merging if no more comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-817] Fix issue for quer...

2016-04-21 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/845#issuecomment-213123847 merging if no more comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-817] Fix issue for quer...

2016-04-20 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/845#issuecomment-212651898 looks good, thanks for the fix. Is this something that can be added to the interpreter doc, an example on how to query fields? --- If your project is

[GitHub] incubator-zeppelin pull request: ZEPPELIN-815 don't create a sub s...

2016-04-20 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/844#issuecomment-212638923 Would the interpreters be a problem for your case? Individual interpreter processes are started by interpreter.sh --- If your project is set up for it

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-798] Migrate to Jetty v...

2016-04-19 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/831#issuecomment-212142078 @echarles could you follow up on the review comments? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-zeppelin pull request: ZEPPELIN-815 don't create a sub s...

2016-04-19 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/844#issuecomment-212115679 + @Leemoonsoo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-789] Skip execution of ...

2016-04-16 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/812#issuecomment-210924078 Does not seem like it, could you please close and reopen this PR to kick off Travis CI again? --- If your project is set up for it, you can reply to

[GitHub] incubator-zeppelin pull request: Improve README.md

2016-04-16 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/839#issuecomment-210753452 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: Fix unwanted link in README.md

2016-04-15 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/838#issuecomment-210690599 would be better to put `-Pmapr[version]` in `? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-788] Update Lens interp...

2016-04-15 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/811#issuecomment-210688863 LGTM merging if no more comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-zeppelin pull request: update VM readme and VM install d...

2016-04-13 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/826#issuecomment-209715236 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-741] Re-use existing pa...

2016-04-13 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/832#issuecomment-209713979 LGTM. merging if no more comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-799] Add python edit mo...

2016-04-13 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/825#issuecomment-209265443 cool thanks, looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-zeppelin pull request: ZEPPELIN-773 : Livy interperter

2016-04-12 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/827#issuecomment-209128251 cool - as commented, will there be ways to allow for livy session control? I've seen cases where users are not aware of the session mechanics and e

[GitHub] incubator-zeppelin pull request: D3 Plotting change and Allow cust...

2016-04-11 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/777#issuecomment-208557436 Seems like this PR should be split into 2 JIRAs? It would be better to track changes this way. --- If your project is set up for it, you can reply to

[GitHub] incubator-zeppelin pull request: Add tooltip for notes reload butt...

2016-04-11 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/813#issuecomment-208556365 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: Fix compilation issues on branch ...

2016-04-11 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/819#issuecomment-208550856 I think that's a fair point we need to consider to support community. But as @bzz says we don't currently have any plan for more release

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-800] Change 0.5.5 and 0...

2016-04-11 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/828#issuecomment-208544670 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-572] pyspark interprete...

2016-04-07 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/605#issuecomment-207245967 Are you sure you are setting master to yarn-client? On Wed, Apr 6, 2016 at 8:27 PM -0700, "yaphet&quo

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-772] - Improve text app...

2016-04-07 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/804#issuecomment-207242160 Ah that makes perfect sense, thanks for the detailed explanation. LGTM. --- If your project is set up for it, you can reply to this

[GitHub] incubator-zeppelin pull request: ZEPPELIN-783: fix Spark download ...

2016-04-07 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/818#issuecomment-207239148 Looks good - sorry for the delay. My only thought was that we should probably echo the exit code from wget if it is not zero in download_with_retry

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-788] Update Lens interp...

2016-04-04 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/811#issuecomment-205286348 This was failing because of a corrupted download as wellhttps://s3.amazonaws.com/archive.travis-ci.org/jobs/120505168/log.txt --- If your

[GitHub] incubator-zeppelin pull request: ZEPPELIN-783 fix CI failure on Sp...

2016-04-04 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/810#issuecomment-205284680 This indicates a corrupted file (which seems fairly common) so would not seem to be download timeout related: https://s3.amazonaws.com

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-781] Update Flink inter...

2016-04-02 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/809#issuecomment-204769459 merging if no more comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-768] HBase 1.1.x and 1....

2016-04-02 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/800#issuecomment-204769269 @vrajat not to worry! we would appreciate your future support and contributions. There are definitely a few great additional features to have, such

[GitHub] incubator-zeppelin pull request: ZEPPELIN-783 fix CI failure on Sp...

2016-04-02 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/810#issuecomment-204763645 yea, unfortunately it seems some of the apache mirrors are very slow.. --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-772] - Improve text app...

2016-04-01 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/804#issuecomment-204644812 Shouldn't all output be captured? Is there a reason we want to clear it when the user navigates out? Perhaps I'm not fully understanding th

[GitHub] incubator-zeppelin pull request: remove overwritten style for p

2016-04-01 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/797#issuecomment-204643388 @johnnyws what's your JIRA account name? Would like to assign this fix to you. Thanks --- If your project is set up for it, you can reply to this

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-707]Automatically adds ...

2016-04-01 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-204586660 Does this work when the user has not included `%interpreter` in the previous paragraph? (ie. using the default interpreter) --- If your project is set

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-781] Update Flink inter...

2016-04-01 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/809#issuecomment-204584598 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: ZEPPELIN-783 fix CI failure on Sp...

2016-04-01 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/810#issuecomment-204571013 Right, dependencies download is another frequent source of download timeout issues. Added a comment on that. --- If your project is set up for it, you

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-760] Companion object b...

2016-03-31 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/794#issuecomment-204069497 merging if no more comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-767] HBase interpreter ...

2016-03-31 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/799#issuecomment-204068310 test failure was: ``` Failed tests: ZeppelinSparkClusterTest.pySparkDepLoaderTest:167->getSparkVersionNumber:220 expected: but

[GitHub] incubator-zeppelin pull request: remove overwritten style for p

2016-03-31 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/797#issuecomment-204068612 merging if no more comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-768] HBase 1.1.x and 1....

2016-03-31 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/800#issuecomment-204067916 merging if no more comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: remove overwritten style for p

2016-03-29 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/797#issuecomment-203052062 ah nice! thanks for the fix. @corneadoug any comment on this css fix? --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-770] Add support for Ma...

2016-03-28 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/803#issuecomment-202604280 looks good to me. any more comment? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-770] Add support for Ma...

2016-03-28 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/803#issuecomment-202604105 test failure was: ``` +tar zxf spark-1.3.1-bin-hadoop2.3.tgz gzip: stdin: not in gzip format tar: Child returned status 1 tar

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-770] Add support for Ma...

2016-03-28 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/803#issuecomment-202556152 Would other components like HBase, Hive work with MapR 5.1? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-760] Companion object b...

2016-03-28 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/794#issuecomment-202517074 @rawkintrevo Please feel free to confine this change if it would help. We could follow up separately for Ignite. --- If your project is set up for

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-768] HBase 1.1.x and 1....

2016-03-27 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/800#issuecomment-202246080 @vrajat @bbuild11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-768] HBase 1.1.x and 1....

2016-03-27 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/incubator-zeppelin/pull/800 [ZEPPELIN-768] HBase 1.1.x and 1.2.0 release support documentation ### What is this PR for? When run with HBase 1.1.x or HBase 1.2.0, this error is reported

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-767] HBase interpreter ...

2016-03-27 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/799#issuecomment-202187238 @vrajat @bbuild11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-767] HBase interpreter ...

2016-03-27 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/incubator-zeppelin/pull/799 [ZEPPELIN-767] HBase interpreter does not work with HBase on a remote cluster ### What is this PR for? HBase interpreter fails with message "ERROR: KeeperErro

[GitHub] incubator-zeppelin pull request: ZEPPELIN-748 make websocket maxTe...

2016-03-27 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/784#issuecomment-202166680 merging if no more comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-183] Interpreter proces...

2016-03-25 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/795#issuecomment-201539303 and what does "instance" mean? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] incubator-zeppelin pull request: remove overwritten style for p

2016-03-25 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/797#issuecomment-201420701 could you share a before/after screenshot --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-751]Log an error and co...

2016-03-22 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/787#issuecomment-200181420 looks good! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-zeppelin pull request: Enhanced resource pool serializat...

2016-03-22 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/782#issuecomment-200179469 looks good, @Leemoonsoo what do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-zeppelin pull request: upgrade angularJS from 1.3.x to 1...

2016-03-22 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/783#issuecomment-200169059 looks good. @corneadoug any issue with this angular version? --- If your project is set up for it, you can reply to this email and have your reply

  1   2   3   4   5   6   7   >