Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/859#issuecomment-217127237
@bzz Done required changes. Please have a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/866#issuecomment-216759102
@prabhjyotsingh thanks for review.
Refactored all the logic into common function.
---
If your project is set up for it, you can reply to this email
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/833#issuecomment-216222460
@bzz
At a time we have set the search results to show at most 20 results. I
feel, for such a small value there should not be any performance
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/859#issuecomment-216158267
@Leemoonsoo @bzz Thanks for review , Fixed indentation and added test.
@bzz thanks for informing , will take care in future PR's
---
If your project
GitHub user ravicodder opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/866
[ZEPPELIN-834]Handle Note-name with spaces
### What is this PR for?
Handle notename to have only white spaces.
### What type of PR is it?
[Bug Fix
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/859#issuecomment-215164810
Ready for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user ravicodder opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/859
[ZEPPELIN-599]notebook search should search paragraph title
### What is this PR for?
Allow notebook search to search paragraph title too.
### What type of PR
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/833#issuecomment-214624711
@bzz Thanks for the review,
I have tried to make test more readable. Please have a look.
---
If your project is set up for it, you can reply
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/833#issuecomment-213894856
@Leemoonsoo @prabhjyotsingh Added test . Please have a look.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/837#issuecomment-213892798
@Leemoonsoo My JIRA user ID is ravicodder . Should I create a JIRA issue
for this change?
---
If your project is set up for it, you can reply
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/837#issuecomment-213713595
@Leemoonsoo No JIRA id for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user ravicodder opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/846
[ZEPPELIN-818]Permissions cannot be cleared
### What is this PR for?
To allow user to clear note permissions .
### What type of PR is it?
[BUG
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/837#issuecomment-210886009
@Leemoonsoo Thanks for review, Test updated .
@prabhjyotsingh Thanks for help.
---
If your project is set up for it, you can reply to this email
GitHub user ravicodder opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/837
Use bootstrap dialog in place of standard confirm
### What is this PR for?
Use bootstrap dialog in place of standard confirm
### What type of PR is it?
Improvement
GitHub user ravicodder opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/833
[ZEPPELIN-705]Search should aware notebook permission
### What is this PR for?
Make search aware of notebook permissions and allow only those search
results for which user has
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/788#issuecomment-199904177
Added limit to size and we can see the complete username on tool tip
