Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/789#issuecomment-205201358
+1...LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/804#issuecomment-204325291
I testedLGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/793#issuecomment-200376077
@Leemoonsoo of course I had forgotten...;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user vgmartinez opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/793
ZEPPELIN-692 Add setting to set s3 endpoint
### What is this PR for?
Add setting to set endpoint in S3 storage
### What type of PR is it?
Improvement
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/668#issuecomment-185103551
hi @felixcheung @jongyoul
This brought up to date nowplease review...;)
---
If your project is set up for it, you can reply to this email
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/667#issuecomment-184589886
hi @felixcheung @jongyoul...I have added more test and fix the other
---
If your project is set up for it, you can reply to this email and have your
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/667#issuecomment-182388974
@jongyoul...Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/667#issuecomment-182490584
@jongyoul
I have added more tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/667#issuecomment-182253519
Hi @felixcheung @jongyoul
I tested it and looks like this:
 as ok, min(title) as t from
films2
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/667#issuecomment-177458549
Hi @felixcheung, could you check the bug...?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-174911726
now I'm busy at work in 1 to 2 days to complete itthanks for review
---
If your project is set up for it, you can reply to this email and have your
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-174887167
Hi @corneadoug,
Yes, you need create a diferent configurations for each db you useand
you can use multiple configuration in the same notebook
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-174890826
To create the configuration is like this:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/660#issuecomment-173242342
Hi @r-kamath,
Nice improvement...LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-173185684
@jongyoul please review and feel free to comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172495765
Hi @tzolov,
Yes, the interpreter is based on the PostgreSQL was mentioned
https://github.com/apache/incubator-zeppelin/pull/608. I think is that we
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172359934
hi @jongyoul,
It ready...in other PR add docs for the interpreter
---
If your project is set up for it, you can reply to this email and have your
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/644#issuecomment-172320004
Hi @malur,
I think it's a good idea to wait to be done merge the Generic JDBC and work
on that to add support for everything related to JDBC
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172103321
Hi @jongyoul @Leemoonsoo,
There is something more to fix or to make the merge...
---
If your project is set up for it, you can reply to this email
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-169939310
Hi @jongyoul,
Is rebase now...let me know if you need help with testing or anything else.
---
If your project is set up for it, you can reply
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-170147338
I removed the dependencies and add the postgres dependency to have it by
default without having to add the jar to the classpath. What do you think
Github user vgmartinez closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/361
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/608#issuecomment-169639840
Hi @jongyoul,
Please review this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user vgmartinez closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/608
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-169696454
Hi @jongyoul,
I think it is not necessary to add another interpreter, I think you can
improve the interpreter hive to add the jars to the classpath
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-164727893
LGTM...
It is a good feature
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-163870545
Hi @jongyoul,
Sorry for my delay ...;) as we move forward with the discussion about the
interpreter jdbc ...? I can improve this withdrawal request
Github user vgmartinez closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/340
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-150933832
Hi @jongyoul,
Thanks for the feedback...I will implement the suggestion
---
If your project is set up for it, you can reply to this email
GitHub user vgmartinez opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/361
JDBC generic interpreter
Only you need to add to the classpath the jdbc connector jar and the
interpreter add the particular properties for each db.
In the file zeppelin
GitHub user vgmartinez opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/343
ZEPPELIN-344 Fix the link to Flink interpreter
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vgmartinez/incubator-zeppelin
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/340#issuecomment-147721881
I also prefer the current rule
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/340#issuecomment-147706453
Hi @Leemoonsoo,
I'm not sure but the test should not be used commitParagraph ? which is
exactly what I should do I'm a little confused
Github user vgmartinez closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/296
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/338#issuecomment-145771668
Hi @abajwa-hw,
Nice improvement...
I think it would be nice implement the test...;)
---
If your project is set up for it, you can reply
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/337#issuecomment-145522570
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/296#issuecomment-140304342
okit makes sense...;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/296#issuecomment-140323804
Hi @corneadoug
it is ready ... any suggestions are welcome;)
---
If your project is set up for it, you can reply to this email and have your
GitHub user vgmartinez opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/296
Add new paragraph when the note is autosaved
When automatically saves the last note, do not add an empty paragraph.
would be necessary to run paragraph is added to an empty one
GitHub user vgmartinez opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/295
Add new paragraph when the note is autosaved
When automatically saves the last note, do not add an empty paragraph.
would be necessary to run paragraph is added to an empty one
Github user vgmartinez closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/295
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user vgmartinez opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/251
remove ace/theme/github
Remove the github theme for editor...fails to load and not using
I've added the comments
any suggestions are welcome...
thks
---
If your project is set up
GitHub user vgmartinez reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/154
Notebook Storage in S3
Storage the notebook in s3, is necesary set the enviroment variable
AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY.
In s3 create a folder structure
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/154#issuecomment-121151720
hi @Leemoonsoo,
I renamed the variables ... any suggestions are welcome...
thanks
---
If your project is set up for it, you can reply
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-120761338
Hi @Madhuka
when you try to resize the paragraph the map does not update to the new
size ... I have seen that you have:
leaflet width=100
67 matches
Mail list logo
