Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/740#issuecomment-197996696
@doanduyhai Thanks for this new api and improvement.
Looks good to me and merge if there're no more discussions.
---
If your project is set up for it
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/740
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user doanduyhai commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/740#issuecomment-197872773
@Leemoonsoo
Sorry, was pretty busy this week.
So regarding your remark on calling `pushAngularObjectRegistryToRemote()`
only once in `Re
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/740#issuecomment-196081077
@doanduyhai Could you take a look a comment for
`pushAngularObjectRegistryToRemote(client);` inside of
RemoteInterpreter.init()
---
If your project is
Github user doanduyhai commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/740#issuecomment-195792892
@Leemoonsoo
Documentation JIRA: https://issues.apache.org/jira/browse/ZEPPELIN-742
Re-use paragraphId on note import JIRA:
https://issues.apa
Github user doanduyhai commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/740#issuecomment-195781145
@Leemoonsoo
Don't worry about documentation, this will be added.
Indeed if you look at the epic **[ZEPPELIN-635]**, I split all changes
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/740#issuecomment-195472242
@doanduyhai Do you mind add someinfo about this new api to
https://github.com/apache/incubator-zeppelin/blob/master/docs/displaysystem/angular.md?
---
If
Github user doanduyhai commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/740#issuecomment-195310144
@Leemoonsoo
Is the PR now ok for merge ? I've modified it to take into account all the
remarks so far
---
If your project is set up for it, you
Github user doanduyhai commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/740#issuecomment-194830614
@Leemoonsoo
> Understood. Sounds nice. (what happen i import the same note again?)
You can re-importe the same note many times, the note
Github user doanduyhai commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/740#issuecomment-194821919
Yes @corneadoug because:
1. binding angular object at note level will require binding this value to
**all** interpreters enabled in this note. Thi
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/740#issuecomment-194776078
Just a quick question in case I missed something, why are we limiting the
angularBind to paragraph level only?
---
If your project is set up for it, you
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/740#issuecomment-192938069
> Your idea can work if we have a paragraph defining HTML element. But what
if I want to bind Angular value to a SparkSQL paragraph or Cassandra paragraph
Github user doanduyhai commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/740#issuecomment-192927095
@Leemoonsoo what do you think about my last proposal ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user doanduyhai commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/740#issuecomment-191840961
> In this perspective, i'm not sure it's good to embed run paragraph inside
of z.angularBind() function in front-end side, while corresponding api in
back
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/740#issuecomment-191504454
two different feature in a function.
> The reason why I add the runParagraph option for z.angularBind() is that
it will be used in 80% of the
Github user doanduyhai commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/740#issuecomment-191418007
@Leemoonsoo
I had a look into the `note.json` file. Indeed we already store the
paragraph id there. Is there any reason that the paragraph id cha
Github user doanduyhai commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/740#issuecomment-190404497
Hello @Leemoonsoo
> I think it's more clear to provide z.runParagraph() than z.angularBind()
has flag of runParagraph.
Having two different f
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/740#issuecomment-190285327
Hi @doanduyhai. Sorry for the late response. I've got some feedbacks here.
# two different feature in a function.
I think it's more clear t
Github user doanduyhai commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/740#issuecomment-190229721
Anyone can have a look into this PR please ? I continue rebasing it from
the master to avoid conflicts when merging and I don't want to do it 10x for
noth
GitHub user doanduyhai opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/740
[Zeppelin 689] Add AngularJS z object and z.angularBind()
### What is this PR for?
Add client-side `z` object with method `angularBind()`
@Leemoonsoo
Compared to
20 matches
Mail list logo
