Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/744
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/744#issuecomment-205101210
@doanduyhai LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user doanduyhai commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/744#issuecomment-205022696
ping @Leemoonsoo @corneadoug
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user doanduyhai commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/744#issuecomment-204690146
Can we merge this PR so I can move to the next sub-task ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/744#issuecomment-203259282
@corneadoug ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/744#issuecomment-202155963
I have tested and working well.
Looks good to me.
@corneadoug Can you take a look, too?
---
If your project is set up for it, you can reply
Github user doanduyhai commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/744#issuecomment-202130699
@corneadoug @Leemoonsoo
Rebased from master, only JS change, can be reviewed and merged quickly.
Do you want me to add also a test in Ze
Github user doanduyhai commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/744#issuecomment-188981265
Right, didn't know that we had ngToast. I never see it in action. Will
remove angular-growl-2
---
If your project is set up for it, you can reply to thi
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/744#issuecomment-188856053
We already have ngtoast for that
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
GitHub user doanduyhai opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/744
[ZEPPELIN-696] Add notification system for AngularJS z functions
### What is this PR for?
Add notification system for AngularJS z functions. Now that we expose the
`z` Angular obj
10 matches
Mail list logo
