Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/713
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/713#issuecomment-189785882
looks good - great contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/713#issuecomment-189680443
Merge if there're no more discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/713#issuecomment-189377126
z.checkbox() works well in Spark and PySpark. also string substitution
works well.
Thanks @zhongneu for great work.
Looks good to me.
---
If
Github user zhongneu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/713#issuecomment-189120617
All tasks are done. Ready for final review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user zhongneu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/713#issuecomment-188623423
@corneadoug The naming of the css class is a little bit confusing. I cannot
use "checkbox" directly, because it seems it will inherit some styles from
other
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/713#issuecomment-187293536
So, from what I saw in the front-end code, a checkbox is considered as a
group of checkbox by default?
I'm going look into it a bit more, in the mean t
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/713#issuecomment-185889236
I tried and it works really well :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user zhongneu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/713#issuecomment-185586523
I've refactored the variable parsing form a little bit to make the
parsing/substation logic consistent, as well as added some unit tests for input
parsing.
Github user zhongneu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/713#issuecomment-184118084
I was a little bit worried about this approach may not be very robust: we
have several reserved characters: `${}|(),`. Because the users will put more
synta
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/713#issuecomment-184112715
Right, multi-selection using string substitution can be complex,
considering target language syntax.
How about just concat selections and let user take
Github user zhongneu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/713#issuecomment-184021909
I found that it is difficult to support multi-selection using string
substitution: ${var=value}, because we do not know how to expand it properly in
a query
Github user zhongneu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/713#issuecomment-184010942
Agreed. I will revoke the changes of the hidden behavior. And thanks for
your example of multi-select using angular. It looks really cool! I also
thought ab
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/713#issuecomment-183999563
You can already add a lot of different dynamic forms to one single
paragraph and it won't look good.
Hiding better be at the form level (dynamic forms
Github user zhongneu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/713#issuecomment-183993992
I think checkbox is a little bit different from other types of forms,
because we may have many checkboxes in a form, and my not look nice if we
cannot hide
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/713#issuecomment-183944263
I'm not sure show/hide option is really necessary in general, since the
goal of the dynamic form is to interact with it. (We don't even hide it in
report
Github user zhongneu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/713#issuecomment-183800463
I've submitted one more commit with better layout and supporting show/hide
options. I do run into an issue: the show/hide option will not be saved.
Currentl
Github user doanduyhai commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/713#issuecomment-183729488
Ok great, thanks for the answer
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user zhongneu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/713#issuecomment-183729056
@doanduyhai Sorry that my last reply is a little bit obscure. I mean we can
use syntax like this:
`${mycheck:checkbox=default1|default2,value1|value2|value3
Github user doanduyhai commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/713#issuecomment-183723243
@zhongneu me either, I didn't know that such syntax ${label:type=...}
exists.
But you did not answer my question. How can I create a dynamic form
Github user zhongneu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/713#issuecomment-183713630
@doanduyhai The current parsing code supports syntax like:
${label:type=...}. I do have concer about this, because from the code I cannot
see what does this
Github user doanduyhai commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/713#issuecomment-183671166
@zhongneu What is the syntax for this dynamic checkbox ?
For example, for input text, the syntax is `${input_text_label=default
value}`
F
Github user AhyoungRyu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/713#issuecomment-183612783
@zhongneu Really appreciate for your quick response! It's not a mandatory,
but it will be good if you create a new one : )
---
If your project is set up
Github user zhongneu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/713#issuecomment-183612251
@AhyoungRyu updated! Shall I create a JIRA for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user AhyoungRyu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/713#issuecomment-183611676
Hi @zhongneu, thanks for your contribution!
For the quick review of this PR, could you apply our [PR
template](https://github.com/apache/incubator-zepp
GitHub user zhongneu opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/713
Add checkbox as a type of dynamic forms
First attempt to add checkbox support for dynamic forms. There are several
concerns:
1. I use Input.type to distinguish between "input",
26 matches
Mail list logo
