Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/688
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/688#issuecomment-182686596
LGTM and merge if there're no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/688#issuecomment-181357941
CI green, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/688#issuecomment-181356761
@prabhjyotsingh Modified test case to include test case to test append
paragraph to top and bottom.
Please have a look.
---
If your project is set
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/688#issuecomment-181284918
@ravicodder I think you should test both append paragraph to top, and
append paragraph to bottom buttons as well. Instead of only testing append to
to
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/688#issuecomment-181280993
Merge if there're no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/688#issuecomment-181252300
@ravicodder Thanks for taking care.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/688#issuecomment-181249777
@Leemoonsoo Modified test case to cover new paragraph by clicking + buttons
between paragraph.
---
If your project is set up for it, you can reply to thi
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/688#issuecomment-181026863
@Leemoonsoo This test does not cover new paragraph by clicking + buttons
between paragraphs
---
If your project is set up for it, you can reply to this e
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/688#issuecomment-180881869
Could this test also cover new paragraph by clicking button between
paragraphs?
---
If your project is set up for it, you can reply to this email and hav
GitHub user ravicodder opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/688
Add new selenium test case for create new paragraph button
The Selenium test case which will test the create new button .
Create new button is for creating new paragraph in a noteb
11 matches
Mail list logo
