Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/693
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/693#issuecomment-189077149
Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/693#issuecomment-188634118
@corneadoug Done rebase.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/693#issuecomment-188605190
@ravicodder I merged one of your test, could you rebase this one?
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/689
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/689#issuecomment-188546460
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/693#issuecomment-188082804
@corneadoug corrected bad rebase.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/689#issuecomment-187600870
@corneadoug Corrected bad rebase.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/693#issuecomment-187318586
Bad rebase again, you are replacing `testRemoveButton()`.
It could be better for you to do a batch of tests instead of a PR for each
of them, because e
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/693#issuecomment-187305700
LGTM :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/689#issuecomment-187291948
Question, why is that test deleting: `testCreateNewButton`? Is that a
result of the rebase?
---
If your project is set up for it, you can reply to this e
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/689#issuecomment-187133115
@prabhjyotsingh used handleException, please have a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/689#issuecomment-186858173
@prabhjyotsingh @corneadoug
Changes has been done, Please have a look.
---
If your project is set up for it, you can reply to this email and have y
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/693#issuecomment-186811605
@prabhjyotsingh thanks for pointing it out.
Required changes has been done.
---
If your project is set up for it, you can reply to this email and have
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/689#issuecomment-186759123
This should catch all Exception not just ElementNotVisibleException.
---
If your project is set up for it, you can reply to this email and have your
r
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/693#issuecomment-186353043
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/693#issuecomment-186235409
@felixcheung Sorry for late response
Conflicts resolved.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/693#issuecomment-185508713
@ravicodder could you please rebase?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/693#issuecomment-185303666
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/689#issuecomment-185311026
CI is now failing on:
```
Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 25.538 sec
<<< FAILURE! - in org.apache.zeppelin.integrat
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/693#issuecomment-185041982
CI green, tested, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/689#issuecomment-185040701
Tested, CI green, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/693#issuecomment-184973712
@prabhjyotsingh could you review this as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/693#issuecomment-183660880
@corneadoug
I accidentally added those files. Sorry for that.
I have made the required changes. Please have a look.
---
If your project is set u
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/693#issuecomment-183540358
@ravicodder There seems to be plenty of unnecessary files in your PR.
The only one needed should be `ParagraphActionsIT.java`
Also for the test itse
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/693#issuecomment-183264411
Ready for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user ravicodder opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/693
Add new selenium test case to test width button for paragraph
##What is this PR for?
Add a new test case for testing the Width button.
##What type of PR is it?
GitHub user ravicodder opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/689
Add new selenium test case to test clear output button
##What is this PR for?
Add a new test case for testing the clear output button.
Clear output button clears the outpu
28 matches
Mail list logo
