[GitHub] incubator-zeppelin pull request: Add new selenium test case to tes...

2016-03-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/693 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-zeppelin pull request: Add new selenium test case to tes...

2016-02-25 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/693#issuecomment-189077149 Merging if there is no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] incubator-zeppelin pull request: Add new selenium test case to tes...

2016-02-24 Thread ravicodder
Github user ravicodder commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/693#issuecomment-188634118 @corneadoug Done rebase. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-zeppelin pull request: Add new selenium test case to tes...

2016-02-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/689 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-zeppelin pull request: Add new selenium test case to tes...

2016-02-22 Thread ravicodder
Github user ravicodder commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/689#issuecomment-187133115 @prabhjyotsingh used handleException, please have a look --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-zeppelin pull request: Add new selenium test case to tes...

2016-02-21 Thread ravicodder
Github user ravicodder commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/689#issuecomment-186858173 @prabhjyotsingh @corneadoug Changes has been done, Please have a look. --- If your project is set up for it, you can reply to this email and have

[GitHub] incubator-zeppelin pull request: Add new selenium test case to tes...

2016-02-20 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/689#issuecomment-186759123 This should catch all Exception not just ElementNotVisibleException. --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-zeppelin pull request: Add new selenium test case to tes...

2016-02-17 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/693#issuecomment-185508713 @ravicodder could you please rebase? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-zeppelin pull request: Add new selenium test case to tes...

2016-02-17 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/693#issuecomment-185303666 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin pull request: Add new selenium test case to tes...

2016-02-17 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/689#issuecomment-185311026 CI is now failing on: ``` Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 25.538 sec <<< FAILURE! - in

[GitHub] incubator-zeppelin pull request: Add new selenium test case to tes...

2016-02-16 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/693#issuecomment-185041982 CI green, tested, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: Add new selenium test case to tes...

2016-02-16 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/693#issuecomment-184973712 @prabhjyotsingh could you review this as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-zeppelin pull request: Add new selenium test case to tes...

2016-02-13 Thread ravicodder
Github user ravicodder commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/693#issuecomment-183660880 @corneadoug I accidentally added those files. Sorry for that. I have made the required changes. Please have a look. --- If your project is set

[GitHub] incubator-zeppelin pull request: Add new selenium test case to tes...

2016-02-12 Thread ravicodder
Github user ravicodder commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/693#issuecomment-183264411 Ready for review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-zeppelin pull request: Add new selenium test case to tes...

2016-02-12 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/693#issuecomment-183540358 @ravicodder There seems to be plenty of unnecessary files in your PR. The only one needed should be `ParagraphActionsIT.java` Also for the test

[GitHub] incubator-zeppelin pull request: Add new selenium test case to tes...

2016-02-04 Thread ravicodder
GitHub user ravicodder opened a pull request: https://github.com/apache/incubator-zeppelin/pull/693 Add new selenium test case to test width button for paragraph ##What is this PR for? Add a new test case for testing the Width button. ##What type of PR is it?

[GitHub] incubator-zeppelin pull request: Add new selenium test case to tes...

2016-02-03 Thread ravicodder
GitHub user ravicodder opened a pull request: https://github.com/apache/incubator-zeppelin/pull/689 Add new selenium test case to test clear output button ##What is this PR for? Add a new test case for testing the clear output button. Clear output button clears the