Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/661
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user AhyoungRyu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-181716399
LGTM : )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-181715598
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-181636680
thanks, merging if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-181620054
Fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-181606224
@vgmartinez sorry, i think my comment has confused you.
Please change this
[line](https://github.com/apache/incubator-zeppelin/pull/661/files#diff-12e
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-181253965
@felixcheung @AhyoungRyu
sorry had not see those comments ... I'm a little distracted
---
If your project is set up for it, you can reply to this
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-181181697
Thanks could you see this comment
https://github.com/apache/incubator-zeppelin/pull/661#discussion_r52105977
and this comment
https://github.com/apac
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-181000409
It's fixed @felixcheung
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-180839625
Thanks, please fix and we should merge this unless anyone has more comment.
---
If your project is set up for it, you can reply to this email and have yo
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-180065614
I fixed @felixcheung...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-180059105
couple of questions, thanks for adding more details
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-179962239
Awesome! I think its good, waiting for @felixcheung in case he sees
something to change
---
If your project is set up for it, you can reply to this email
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-179960076
Hi @corneadoug,
* yes, you can.
name
value
common.max_count
1000
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-179955072
@vgmartinez I liked the improvements, that was easy to read and
self-explanatory.
Just a couple of questions about the JDBC interpreter:
* Is
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-179879267
@felixcheung @corneadoug ready to review...I think it is ready...
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-174913559
No problem
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-174911726
now I'm busy at work in 1 to 2 days to complete itthanks for review
---
If your project is set up for it, you can reply to this email and have your
re
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-174906314
To me there is still plenty of things missing in the doc:
* Database part is not mentioned anywhere (it seems it is part of the url)
* `The connecti
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-174890826
To create the configuration is like this:
`?
Is it the name used to create the interpreter in the interpreter tab?
---
If yo
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-174887167
Hi @corneadoug,
Yes, you need create a diferent configurations for each db you useand
you can use multiple configuration in the same notebook this
Github user beeva-victorgarcia commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-174886282
Hi @corneadoug,
yes, you need create a diferent configurations for each db you useand
you can use multiple configuration in the same noteb
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-174861186
Yes it would be better to have it documented then.
So, that means you need to create a different interpreter configuration for
each database you want t
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-174848324
It depends on the type, but database name is normally part of the jdbc url:
https://www.petefreitag.com/articles/jdbc_urls/
maybe we should show
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-174355014
One question about that interpreter, how do you specify the database you
want to use?
---
If your project is set up for it, you can reply to this email a
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-174343949
Thanks @vgmartinez for the documentation.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-174310266
Hi @AhyoungRyuIt done
thank for review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user AhyoungRyu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-174306226
Hi @vgmartinez, thank you for a new JDBC interpreter and the docs! : )
If you want to add a docs for new interpreter, you have to provide a link
for i
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-174299371
Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user beeva-victorgarcia commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-174299340
Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-174239528
pending some text fix, looks good.
merging if there is no more discussion, thanks.
---
If your project is set up for it, you can reply to this email
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-174239116
ok...it ready now...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-174238774
@vgmartinez thanks, but to clarify, I think it's fine that you have images
to show results along with the code that can be pasted.
As of now tho
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-174092905
I'm sorry;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-174088641
thx, you might have forgotten to take out images replaced with text from
this PR?
---
If your project is set up for it, you can reply to this email and
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-173985892
thanks @felixcheungIt is much better now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/661#issuecomment-173185684
@jongyoul please review and feel free to comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user vgmartinez opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/661
Docs for jdbc interpreter
## What is this PR for?
Docs for jdbc interpreter
## What type of PR is it?
Documentation
## Todos
## Is there a
39 matches
Mail list logo
