[GitHub] incubator-zeppelin pull request: Enhanced resource pool serializat...

2016-04-01 Thread fireboy1919
Github user fireboy1919 commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/782#issuecomment-204451849 @Leemoonsoo: does this address everything? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] incubator-zeppelin pull request: Enhanced resource pool serializat...

2016-03-28 Thread fireboy1919
Github user fireboy1919 commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/782#issuecomment-202581884 The second one. And I have a solution that does that in this pull request now. I didn't remove the interpreter serializer from this pull

[GitHub] incubator-zeppelin pull request: Enhanced resource pool serializat...

2016-03-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/782#issuecomment-202459832 Thanks for the understanding. I think term 'resource', 'remote resource' are bit confusing in this conversation. if i define, Resource -

[GitHub] incubator-zeppelin pull request: Enhanced resource pool serializat...

2016-03-28 Thread fireboy1919
Github user fireboy1919 commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/782#issuecomment-202411857 That makes sense. The issue is that "ResourcePoolUtils" currently doesn't use that enhanced method, and if you're trying to get a specific resource, that

[GitHub] incubator-zeppelin pull request: Enhanced resource pool serializat...

2016-03-25 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/782#issuecomment-201719098 ResourcePool supposed to allow any resource. From not serializable object such as SparkContext, to very large object. `Object r` field in `class Resource`

[GitHub] incubator-zeppelin pull request: Enhanced resource pool serializat...

2016-03-22 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/782#issuecomment-200179469 looks good, @Leemoonsoo what do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-zeppelin pull request: Enhanced resource pool serializat...

2016-03-22 Thread fireboy1919
Github user fireboy1919 commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/782#issuecomment-199814378 I have finished work on the other three tasks on the list that I mentioned above - which are not included to make the request easier to review. --- If y

[GitHub] incubator-zeppelin pull request: Enhanced resource pool serializat...

2016-03-21 Thread fireboy1919
Github user fireboy1919 commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/782#issuecomment-199269648 That's why I only have the first TODO done: it's the smallest case I could think of. It's only the serializer and the place where it gets used

[GitHub] incubator-zeppelin pull request: Enhanced resource pool serializat...

2016-03-19 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/782#issuecomment-198111341 @fireboy1919 are the ToDos list of items completed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] incubator-zeppelin pull request: Enhanced resource pool serializat...

2016-03-19 Thread fireboy1919
Github user fireboy1919 commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/782#issuecomment-198048450 @Leemoonsoo: This is ready to go, and is based upon your previous work. --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-zeppelin pull request: Enhanced resource pool serializat...

2016-03-19 Thread fireboy1919
Github user fireboy1919 commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/782#issuecomment-198351846 I was going to make a different request for each of those. I have one ready for the second item, too, but i figured that smaller was better. Sho

[GitHub] incubator-zeppelin pull request: Enhanced resource pool serializat...

2016-03-18 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/782#issuecomment-198610147 It might help to break this up into smaller PR to help review and getting it merged. --- If your project is set up for it, you can reply to this email a