Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/679#issuecomment-179580019
Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/679#issuecomment-179371302
Except for that last comment, LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AhyoungRyu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/679#issuecomment-178491535
@felixcheung
I really appreciate to your detailed explanation! I applied your comments
and pushed again : )
---
If your project is set up for it,
Github user AhyoungRyu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/679#issuecomment-177457158
@Leemoonsoo I see. So I applied your comment and pushed it : )
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AhyoungRyu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/679#issuecomment-177152345
@felixcheung You're right.
But I've thought this table is too big to identify at a glance :â-(
Then, how about adding a note sentence below( or
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/679#issuecomment-177030666
The tabs are nice but would it be better to put -env.sh in a column,
-site.xml in another in one table? They have a lot overlap?
---
If your project is
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/679
Fix dead link and add table tab to Zeppelin Configuration section:
docs/install/install.md
### What is this PR for?
As mentioned at
