[GitHub] incubator-zeppelin pull request: Simple improvement to showDF() to...

2016-02-08 Thread markncooper
Github user markncooper closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/699 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] incubator-zeppelin pull request: Simple improvement to showDF() to...

2016-02-08 Thread jongyoul
Github user jongyoul commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/699#issuecomment-181715206 @markncooper Could you please close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] incubator-zeppelin pull request: Simple improvement to showDF() to...

2016-02-07 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/699#issuecomment-181183655 @markncooper #695 is merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] incubator-zeppelin pull request: Simple improvement to showDF() to...

2016-02-06 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/699#issuecomment-180837301 looks good - it seems we have some duplications here, perhaps @markncooper you would like to refactor this after #695 is merged to a util method? --- If

[GitHub] incubator-zeppelin pull request: Simple improvement to showDF() to...

2016-02-05 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/699#issuecomment-180578411 @markncooper Actually you are not touching the same code lines, so maybe both would give better performances --- If your project is set up for it, you ca

[GitHub] incubator-zeppelin pull request: Simple improvement to showDF() to...

2016-02-05 Thread markncooper
Github user markncooper commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/699#issuecomment-180571755 Oops, I see this was just fixed with this change: https://github.com/apache/incubator-zeppelin/pull/695 --- If your project is set up for it, yo

[GitHub] incubator-zeppelin pull request: Simple improvement to showDF() to...

2016-02-05 Thread markncooper
GitHub user markncooper opened a pull request: https://github.com/apache/incubator-zeppelin/pull/699 Simple improvement to showDF() to use StringBuilder **What is this PR for? The way tables of results are currently getting built within the ZeppelinContext is pretty slow due