[GitHub] incubator-zeppelin pull request: Use bootstrap dialog in place of ...

2016-04-24 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/837#issuecomment-214146221 @ravicodder i was asking JIRA user ID for ZEPPELIN-818, somehow i commented here by mistake. Having JIRA issue is not mandatory but i think it's always go

[GitHub] incubator-zeppelin pull request: Use bootstrap dialog in place of ...

2016-04-23 Thread ravicodder
Github user ravicodder commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/837#issuecomment-213892798 @Leemoonsoo My JIRA user ID is ravicodder . Should I create a JIRA issue for this change? --- If your project is set up for it, you can reply to this em

[GitHub] incubator-zeppelin pull request: Use bootstrap dialog in place of ...

2016-04-23 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/837#issuecomment-213853600 @ravicodder Also can i ask your user ID on [JIRA](https://issues.apache.org/jira/browse/ZEPPELIN)? --- If your project is set up for it, you can reply to

[GitHub] incubator-zeppelin pull request: Use bootstrap dialog in place of ...

2016-04-23 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/837#issuecomment-213791755 My bad. Are you asking if this issue should have a JIRA to track this change? --- If your project is set up for it, you c

[GitHub] incubator-zeppelin pull request: Use bootstrap dialog in place of ...

2016-04-23 Thread ravicodder
Github user ravicodder commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/837#issuecomment-213713595 @Leemoonsoo No JIRA id for this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: Use bootstrap dialog in place of ...

2016-04-23 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/837#issuecomment-213704877 @ravicodder Do you have JIRA id? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] incubator-zeppelin pull request: Use bootstrap dialog in place of ...

2016-04-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/837 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-zeppelin pull request: Use bootstrap dialog in place of ...

2016-04-21 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/837#issuecomment-213186699 thx. any more comment? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] incubator-zeppelin pull request: Use bootstrap dialog in place of ...

2016-04-16 Thread ravicodder
Github user ravicodder commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/837#issuecomment-210886009 @Leemoonsoo Thanks for review, Test updated . @prabhjyotsingh Thanks for help. --- If your project is set up for it, you can reply to this email and h

[GitHub] incubator-zeppelin pull request: Use bootstrap dialog in place of ...

2016-04-15 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/837#issuecomment-210742857 you need to fix it https://github.com/apache/incubator-zeppelin/pull/837/files#diff-a7fb72a3220c2a1f756a04eaa5cf1dc6R245 as well --- If your project

[GitHub] incubator-zeppelin pull request: Use bootstrap dialog in place of ...

2016-04-15 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/837#issuecomment-210722868 Thanks for the improvement. There're a [test case](https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-server/src/test/java/org/apac

[GitHub] incubator-zeppelin pull request: Use bootstrap dialog in place of ...

2016-04-14 Thread ravicodder
GitHub user ravicodder opened a pull request: https://github.com/apache/incubator-zeppelin/pull/837 Use bootstrap dialog in place of standard confirm ### What is this PR for? Use bootstrap dialog in place of standard confirm ### What type of PR is it? Improvement