[GitHub] incubator-zeppelin pull request: User in interpreter context

2016-02-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/705 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-zeppelin pull request: User in interpreter context

2016-02-21 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/705#issuecomment-186989791 Thank you for reviewing this. Have merged this with master. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] incubator-zeppelin pull request: User in interpreter context

2016-02-21 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/705#issuecomment-186915557 Let's rebase and merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] incubator-zeppelin pull request: User in interpreter context

2016-02-20 Thread jongyoul
Github user jongyoul commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/705#issuecomment-186631173 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] incubator-zeppelin pull request: User in interpreter context

2016-02-19 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/705#issuecomment-186360054 Thanks @prabhjyotsingh. It looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-zeppelin pull request: User in interpreter context

2016-02-18 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/705#issuecomment-186065829 Thanks you @Leemoonsoo, that does make a lot of sense. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-zeppelin pull request: User in interpreter context

2016-02-17 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/705#issuecomment-185582355 I have tried and it works well. One thing is, `org.apache.zeppelin.display` package supposed to have Display System related codes. I think `Authent

[GitHub] incubator-zeppelin pull request: User in interpreter context

2016-02-16 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/705#issuecomment-184762793 Thank you for the suggestion @Leemoonsoo. Have added AuthenticationInfo class, and made relevant changes. --- If your project is set up for it, you c

[GitHub] incubator-zeppelin pull request: User in interpreter context

2016-02-14 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/705#issuecomment-183990823 I think it make sense to let access authentication info through InterpreterContext. But i think authentication info will be more than a user name in th

[GitHub] incubator-zeppelin pull request: User in interpreter context

2016-02-14 Thread rconline
Github user rconline commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/705#issuecomment-183897757 @felixcheung @prabhjyotsingh The purpose of this discussion should be to get to an approach that allows us zeppelin to do a couple of things - pass user id

[GitHub] incubator-zeppelin pull request: User in interpreter context

2016-02-13 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/705#issuecomment-183823300 @prabhjyotsingh could you explain more on the reason for this change? Also this seems like a somewhat big change - could you open a JIRA on this so it

[GitHub] incubator-zeppelin pull request: User in interpreter context

2016-02-12 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/705#issuecomment-183499201 @rconline how would you want to discuss? Should we open a JIRA - or a JIRA parent with subtests for this multi-user auth use cases? --- If your project

[GitHub] incubator-zeppelin pull request: User in interpreter context

2016-02-11 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/705#issuecomment-183166585 This is ready for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] incubator-zeppelin pull request: User in interpreter context

2016-02-09 Thread rconline
Github user rconline commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/705#issuecomment-181871112 This is a requisite first step for getting to multi-user scenarios. I believe this should get discussed a little bit in terms of approach. --- If your pro

[GitHub] incubator-zeppelin pull request: User in interpreter context

2016-02-09 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/incubator-zeppelin/pull/705 User in interpreter context ### What is this PR for? The goal of the PR is to pass userName/userInfo from front-end to interpreters. The PR uses Shiro authentication(http