[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-05-19 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-220496295 @yantaiv Better ask that in the mailing list, you would get more answers But overall: You can use any IDE you want, there is informations about dev

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-05-19 Thread yantaiv
Github user yantaiv commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-220495083 Great Job. I have a silly question, how do you debug your code in zeppelin, I mean , what IDE do you use and how you make breakpoint or sth like that ... -

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-05-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/858 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-05-12 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-218786751 Merging if there is no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-05-12 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-218786264 @corneadoug I'm following up on handsontable repo. Will find some time to explore for a potential PR. --- If your project is set up for it, you can reply t

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-05-12 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-218681550 @r-kamath I don't want to make this PR wait forever. If it was easy to do, I would prefer removing those dependencies. Mainly because everytime we want

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-05-10 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-218190257 @corneadoug Again, this is an issue on handsontable please follow these links. Those entries in index.html should disappear when handsontable team fix the i

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-05-10 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-218183698 I don't get why its not important to have additional dependencies that we are not using in our build if its not in bower.json, maybe somebody can explain

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-05-10 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-218164861 I would agree with @r-kamath, as long as those dependencies are not been written in bower.json we should be ok. https://github.com/apache/incubato

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-05-10 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-218142389 Not sure if we can avoid those dependencies by choosing hot-builder! Though we are not using the copy/ paste, date picker and date formatting, it is stil

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-05-10 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-218139724 @r-kamath https://github.com/handsontable/hot-builder I understand that by default it seems to be needed, however I'm reticent to include 3 different d

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-05-10 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-218138415 @corneadoug [Use without pikaday #2841](https://github.com/handsontable/handsontable/issues/2841) --- If your project is set up for it, you can reply to t

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-05-10 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-218131360 Anyway to not have: * zeroclipboard * pikaday * moment included when installing Handsontable? --- If your project is set up for it, y

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-05-09 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-218072879 Thanks @r-kamath for contributing towards front-end performance. Merging if no more discussion. --- If your project is set up for it, you can rep

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-05-09 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-218056874 @prabhjyotsingh conflict resolved f13ba91 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-05-09 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-217864642 @r-kamath can you resolve branch conflict. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-05-05 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-217091158 @felixcheung this PR is only for improving table performance. CSV/TSV export is in #725 and #714 --- If your project is set up for it, you can reply to thi

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-05-04 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-217047637 @felixcheung No, There is still no export to CSV feature --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-05-04 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-217005186 does this PR change the export to CSV capability? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-05-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-216957711 Last CI test failure is unrelated to the change. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-05-04 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-216956720 @Leemoonsoo cool. I have checked the 'UI fixes'. thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-05-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-216955848 Arrow style looks fine. I think it's good to be merged! --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-05-04 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-216953422 @Leemoonsoo the only pending item is the sort header arrow style. Should we try something more stylish ? https://cloud.githubusercontent.com/assets/20313

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-05-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-216951554 @r-kamath Are there any more works left for unchecked todo item 'UI fixes', in the description of this PR? --- If your project is set up for it, you can

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-05-04 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-216916049 LGTM! nice improvement 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-05-02 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-216121658 @Leemoonsoo license doc updated and rebased 2e422ea 4fbb22b --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-04-29 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-215929882 %html rendering is working nicely! If pickaday.js, moment.js, ZeroClipboard.js are required to use handsontable, they also need to be in 'zeppelin-distrib

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-04-29 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-215672145 @Leemoonsoo `%html` rendering is fixed in 44ef274 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-04-28 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-215517988 @Leemoonsoo that's in the todo list. Can be done either in FE or in server. Thoughts? --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-04-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-215516220 Is it possible to handle '%html' inside of table cell? if i run ``` println(s"""%table key\tvalue html\t%html blue """) ```

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-04-27 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-215308849 Right, it is supported only in pro ver. Handsontable's Export feature is in front-end. IMHO export should be a backend feature and will be a good addition t

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-04-27 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-215225519 We would need export to file feature which seems like is not supported in the free Handsontable version? --- If your project is set up for it, you can

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-04-27 Thread r-kamath
Github user r-kamath commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-215040456 Won't affect #714 and #725 #6 and #761 are using jQuery Datatables This PR is a proposal to use Handsontable instead of datatables. Handsontable

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-04-26 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-214847192 How does this work with some of the pending data table changes? like #6, #714, #725, #761 --- If your project is set up for it, you can reply to thi

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-04-26 Thread astroshim
Github user astroshim commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-214765937 I passed the build with no problems and functionality is working very well. but @r-kamath you should make the green CI. Thanks. --- If your projec

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-04-26 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-214751923 @r-kamath build fails with Failed tests: SparkParagraphIT.testSqlSpark:169 Paragraph from SparkParagraphIT of testSqlSpar

[GitHub] incubator-zeppelin pull request: ZEPPELIN-830 Improve table displa...

2016-04-26 Thread r-kamath
GitHub user r-kamath opened a pull request: https://github.com/apache/incubator-zeppelin/pull/858 ZEPPELIN-830 Improve table display to handle large data ### What is this PR for? This is an improvement for table display. By using [Handsontable](https://github.com/handsontable/ha