Re: AngularObjecRegistry vs RemoteAngularObjectRegistry, need your thoughs

2016-01-27 Thread DuyHai Doan
Implemented in this PR : https://github.com/apache/incubator-zeppelin/pull/678 I did not change the addAndNotifyRemoteProcess() and its remove corresponding methods. For now I just let them as they are. We may think about improving the design when we refactor the code later On Sun, Jan 24, 2016 a

Re: AngularObjecRegistry vs RemoteAngularObjectRegistry, need your thoughs

2016-01-24 Thread moon soo Lee
Adding angularRegistryPush() and pushing angularobjects on interpreter initialize sounds like a good plan. But overriding add() and removing addAndNotifyRemoteProcess may need something more. Because update from interpreter side sent to zeppelin server will be update RemoteAngularObjectRegistry us

Re: AngularObjecRegistry vs RemoteAngularObjectRegistry, need your thoughs

2016-01-24 Thread DuyHai Doan
There is a elegant solution for this. I'm adding a new Thrift method called angularRegistryPush(). The idea is that every time the RemoteInterpreter start a new remote Interpreter, after the call to client.createInterpreter(...): 1. we retrieve the ZeppelinServer-local angular registry for this

Re: AngularObjecRegistry vs RemoteAngularObjectRegistry, need your thoughs

2016-01-23 Thread moon soo Lee
Hi DuyHai, Thanks for interest to AngularObject. In short, RemoteAngularObjectRegistry is proxy for AngularObjectRegistry that running in interpreter process. Once an AngularObject is created, the object stays in both RemoteAngularObjectRegistry (in zeppelinServer) and AngularObjectRegistry (in

Re: AngularObjecRegistry vs RemoteAngularObjectRegistry, need your thoughs

2016-01-23 Thread DuyHai Doan
It's even worst than what I though, addAndNotifyRemoteProcess() is never used in production code, only called by an unit test. The method Notebook.loadNoteFromRepo() just mention it in a comment: // at this point, remote interpreter process is not created. // so does not make

AngularObjecRegistry vs RemoteAngularObjectRegistry, need your thoughs

2016-01-23 Thread DuyHai Doan
Hello guys While developing a new feature, I can see some inconsistencies in the design of the AngularObjecRegistry and RemoteAngularObjectRegistry classes. The remote class extends the base AngularObjecRegistry class, so it also inherits the values HashMap. The problem is that this value Has