[GitHub] incubator-zeppelin pull request: ZEPPELIN-299 Support clearing out...

2015-11-04 Thread rconline
Github user rconline commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/372#issuecomment-153979630 Looks good, useful feature. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: Hot Fix - Remove Karma coverage

2015-11-05 Thread rconline
Github user rconline commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/390#issuecomment-153982076 @corneadoug having coverage is a good idea. We should look at the issue one more time. --- If your project is set up for it, you can reply to this email

[GitHub] incubator-zeppelin pull request: Remove deprecated grunt-autoprefi...

2015-11-16 Thread rconline
Github user rconline commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/438#issuecomment-157002527 Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-zeppelin pull request: Added Shiro security

2015-12-29 Thread rconline
Github user rconline commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/53#issuecomment-167797523 @jongyoul @elbamos @hayssams this change is an important one, and we should try to get this in. My two cents on how we could divide the whole pull request

[GitHub] incubator-zeppelin pull request: Added Shiro security

2015-12-29 Thread rconline
Github user rconline commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/53#issuecomment-167866687 @hayssams please do that, it will be great. I can help with Junits, Docs and separation, should you need it, will commit into your branches, which can then

[GitHub] incubator-zeppelin pull request: Tested with local LDAP configurat...

2016-01-12 Thread rconline
GitHub user rconline opened a pull request: https://github.com/apache/incubator-zeppelin/pull/625 Tested with local LDAP configurations. ### What is this PR for? @hayssams @Leemoonsoo Just tested https://github.com/apache/incubator-zeppelin/pull/586 with a local LDAP, works

[GitHub] incubator-zeppelin pull request: Tested with local LDAP configurat...

2016-01-12 Thread rconline
Github user rconline commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/625#issuecomment-170909250 @hayssams thanks for pointing out. Made the change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-zeppelin pull request: ZEPPELIN-491: Giving fixed height...

2016-02-09 Thread rconline
Github user rconline commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/519#issuecomment-181870734 Looks good. Can we get some attention from committers. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-zeppelin pull request: User in interpreter context

2016-02-09 Thread rconline
Github user rconline commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/705#issuecomment-181871112 This is a requisite first step for getting to multi-user scenarios. I believe this should get discussed a little bit in terms of approach. --- If your

[GitHub] incubator-zeppelin pull request: User in interpreter context

2016-02-14 Thread rconline
Github user rconline commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/705#issuecomment-183897757 @felixcheung @prabhjyotsingh The purpose of this discussion should be to get to an approach that allows us zeppelin to do a couple of things - pass user