ZooKeeper-trunk-solaris - Build # 395 - Failure

2012-11-28 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-solaris/395/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 148842 lines...] [junit] 2012-11-28

[jira] [Commented] (ZOOKEEPER-1590) Patch to add zk.updateServerList(newServerList) broke the build

2012-11-28 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505365#comment-13505365 ] Hudson commented on ZOOKEEPER-1590: --- Integrated in ZooKeeper-trunk #1757 (See

[jira] [Commented] (ZOOKEEPER-1474) Cannot build Zookeeper with IBM Java: use of Sun MXBean classes

2012-11-28 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505364#comment-13505364 ] Hudson commented on ZOOKEEPER-1474: --- Integrated in ZooKeeper-trunk #1757 (See

[jira] [Updated] (ZOOKEEPER-1564) Allow JUnit test build with IBM Java

2012-11-28 Thread Paulo Ricardo Paz Vital (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Ricardo Paz Vital updated ZOOKEEPER-1564: --- Summary: Allow JUnit test build with IBM Java (was: Allow

[jira] [Updated] (ZOOKEEPER-1564) Allow JUnit test build with IBM Java

2012-11-28 Thread Paulo Ricardo Paz Vital (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Ricardo Paz Vital updated ZOOKEEPER-1564: --- Description: The org.apache.zookeeper.test.ClientBase,

ZooKeeper-trunk-WinVS2008 - Build # 598 - Still Failing

2012-11-28 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/598/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 108 lines...] [javac] Compiling 39 source

[jira] [Updated] (ZOOKEEPER-1564) Allow JUnit test build with IBM Java

2012-11-28 Thread Paulo Ricardo Paz Vital (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Ricardo Paz Vital updated ZOOKEEPER-1564: --- Affects Version/s: 3.4.5 Allow JUnit test build with IBM

[jira] [Assigned] (ZOOKEEPER-1564) Allow JUnit test build with IBM Java

2012-11-28 Thread Paulo Ricardo Paz Vital (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Ricardo Paz Vital reassigned ZOOKEEPER-1564: -- Assignee: Paulo Ricardo Paz Vital Allow JUnit test

[jira] [Updated] (ZOOKEEPER-1564) Allow JUnit test build with IBM Java

2012-11-28 Thread Paulo Ricardo Paz Vital (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Ricardo Paz Vital updated ZOOKEEPER-1564: --- Fix Version/s: 3.4.5 Allow JUnit test build with IBM Java

[jira] [Updated] (ZOOKEEPER-1564) Allow JUnit test build with IBM Java

2012-11-28 Thread Paulo Ricardo Paz Vital (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Ricardo Paz Vital updated ZOOKEEPER-1564: --- Attachment: ZOOKEEPER-1564-v2.patch Patch using the wrapper

[jira] [Resolved] (ZOOKEEPER-1565) Allow ClientTest.java build with IBM Java

2012-11-28 Thread Paulo Ricardo Paz Vital (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Ricardo Paz Vital resolved ZOOKEEPER-1565. Resolution: Duplicate Duplicate of ZOOKEEPER-1564

[jira] [Resolved] (ZOOKEEPER-1570) Allow QuorumBase.java build with IBM Java

2012-11-28 Thread Paulo Ricardo Paz Vital (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Ricardo Paz Vital resolved ZOOKEEPER-1570. Resolution: Duplicate Duplicate of ZOOKEEPER-1564

[jira] [Resolved] (ZOOKEEPER-1571) Allow QuorumUtil.java build with IBM Java

2012-11-28 Thread Paulo Ricardo Paz Vital (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Ricardo Paz Vital resolved ZOOKEEPER-1571. Resolution: Duplicate Duplicate of ZOOKEEPER-1564

Success: ZOOKEEPER-1564 PreCommit Build #1274

2012-11-28 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1564 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1274/ ### ## LAST 60 LINES OF THE CONSOLE ###

[jira] [Commented] (ZOOKEEPER-1564) Allow JUnit test build with IBM Java

2012-11-28 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505383#comment-13505383 ] Hadoop QA commented on ZOOKEEPER-1564: -- +1 overall. Here are the results of

[jira] [Commented] (ZOOKEEPER-1578) org.apache.zookeeper.server.quorum.Zab1_0Test failed due to hard code with 33556 port

2012-11-28 Thread Li Ping Zhang (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505413#comment-13505413 ] Li Ping Zhang commented on ZOOKEEPER-1578: -- By the way, can I have the honor

[jira] [Commented] (ZOOKEEPER-1578) org.apache.zookeeper.server.quorum.Zab1_0Test failed due to hard code with 33556 port

2012-11-28 Thread Li Ping Zhang (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505412#comment-13505412 ] Li Ping Zhang commented on ZOOKEEPER-1578: -- Dear Zookeeper committee, I have

[jira] [Commented] (ZOOKEEPER-1400) Allow logging via callback instead of raw FILE pointer

2012-11-28 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505568#comment-13505568 ] Hadoop QA commented on ZOOKEEPER-1400: -- -1 overall. Here are the results of

Failed: ZOOKEEPER-1400 PreCommit Build #1275

2012-11-28 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1400 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1275/ ### ## LAST 60 LINES OF THE CONSOLE ###

[jira] [Commented] (ZOOKEEPER-1568) multi should have a non-transaction version

2012-11-28 Thread Jimmy Xiang (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505588#comment-13505588 ] Jimmy Xiang commented on ZOOKEEPER-1568: I am hacking around this week. I will

Re: Review Request: ZOOKEEPER-1346: Handle 4lws and monitoring on separate port (creating jetty server)

2012-11-28 Thread Patrick Hunt
On Nov. 18, 2012, 4:10 p.m., Camille Fournier wrote: src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java, line 306 https://reviews.apache.org/r/8094/diff/1/?file=190875#file190875line306 Why make this a more restrictive type? Skye Wanderman-Milne wrote: If

Re: Review Request: ZOOKEEPER-1346: Handle 4lws and monitoring on separate port (creating jetty server)

2012-11-28 Thread Patrick Hunt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8094/#review13824 --- This looks good to me overall short of the following comments.

Re: Review Request: ZOOKEEPER-1346: Handle 4lws and monitoring on separate port (creating jetty server)

2012-11-28 Thread Skye Wanderman-Milne
On Nov. 18, 2012, 4:10 p.m., Camille Fournier wrote: src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java, line 306 https://reviews.apache.org/r/8094/diff/1/?file=190875#file190875line306 Why make this a more restrictive type? Skye Wanderman-Milne wrote: If

Re: Review Request: ZOOKEEPER-1346: Handle 4lws and monitoring on separate port (creating jetty server)

2012-11-28 Thread Skye Wanderman-Milne
On Nov. 28, 2012, 6:19 p.m., Patrick Hunt wrote: src/java/main/org/apache/zookeeper/server/DataTree.java, line 1216 https://reviews.apache.org/r/8094/diff/1/?file=190874#file190874line1216 this doesn't need synchronization? I should be synchronizing and copying the HashSet values

Re: Review Request: ZOOKEEPER-1346: Handle 4lws and monitoring on separate port (creating jetty server)

2012-11-28 Thread Henry Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8094/#review13826 --- Looking good.

Re: Review Request: ZOOKEEPER-1346: Handle 4lws and monitoring on separate port (creating jetty server)

2012-11-28 Thread Henry Robinson
On Nov. 18, 2012, 4:10 p.m., Camille Fournier wrote: src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java, line 306 https://reviews.apache.org/r/8094/diff/1/?file=190875#file190875line306 Why make this a more restrictive type? Skye Wanderman-Milne wrote: If

[jira] [Updated] (ZOOKEEPER-1568) multi should have a non-transaction version

2012-11-28 Thread Jimmy Xiang (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jimmy Xiang updated ZOOKEEPER-1568: --- Attachment: zk-1568_v2.patch Patch version 2 which supports async batch.

[jira] [Commented] (ZOOKEEPER-1477) Test failures with Java 7 on Mac OS X

2012-11-28 Thread Roman Shaposhnik (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506057#comment-13506057 ] Roman Shaposhnik commented on ZOOKEEPER-1477: - Fedora 18 is not officially

[jira] [Commented] (ZOOKEEPER-1477) Test failures with Java 7 on Mac OS X

2012-11-28 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506227#comment-13506227 ] Patrick Hunt commented on ZOOKEEPER-1477: - Has anyone tried against 3.4.5? Do

[jira] [Updated] (ZOOKEEPER-1578) org.apache.zookeeper.server.quorum.Zab1_0Test failed due to hard code with 33556 port

2012-11-28 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-1578: Assignee: Li Ping Zhang org.apache.zookeeper.server.quorum.Zab1_0Test failed due

[jira] [Updated] (ZOOKEEPER-1584) Adding mvn-install target for deploying the zookeeper artifacts to .m2 repository.

2012-11-28 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-1584: Fix Version/s: (was: 3.4.5) 3.4.6 Adding mvn-install

[jira] [Updated] (ZOOKEEPER-1572) Add an async interface for multi request

2012-11-28 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-1572: Fix Version/s: (was: 3.4.5) 3.4.6 Add an async interface

[jira] [Updated] (ZOOKEEPER-1564) Allow JUnit test build with IBM Java

2012-11-28 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-1564: Fix Version/s: (was: 3.4.5) 3.4.6 Allow JUnit test build

[jira] [Updated] (ZOOKEEPER-1564) Allow JUnit test build with IBM Java

2012-11-28 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-1564: Fix Version/s: (was: 3.4.4) 3.5.0 Allow JUnit test build

[jira] [Updated] (ZOOKEEPER-1564) Allow JUnit test build with IBM Java

2012-11-28 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-1564: Affects Version/s: 3.5.0 Allow JUnit test build with IBM Java

[jira] [Updated] (ZOOKEEPER-107) Allow dynamic changes to server cluster membership

2012-11-28 Thread Alexander Shraer (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shraer updated ZOOKEEPER-107: --- Attachment: ZOOKEEPER-107-28-NOV.patch Removed tabs and some trailing spaces

Failed: ZOOKEEPER-107 PreCommit Build #1276

2012-11-28 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-107 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1276/ ### ## LAST 60 LINES OF THE CONSOLE ###

[jira] [Updated] (ZOOKEEPER-107) Allow dynamic changes to server cluster membership

2012-11-28 Thread Alexander Shraer (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shraer updated ZOOKEEPER-107: --- Attachment: (was: ZOOKEEPER-107-28-NOV.patch) Allow dynamic changes to

[jira] [Commented] (ZOOKEEPER-107) Allow dynamic changes to server cluster membership

2012-11-28 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506244#comment-13506244 ] Hadoop QA commented on ZOOKEEPER-107: - -1 overall. Here are the results of testing

Failed: ZOOKEEPER-107 PreCommit Build #1277

2012-11-28 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-107 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1277/ ### ## LAST 60 LINES OF THE CONSOLE ###

[jira] [Commented] (ZOOKEEPER-107) Allow dynamic changes to server cluster membership

2012-11-28 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506250#comment-13506250 ] Hadoop QA commented on ZOOKEEPER-107: - -1 overall. Here are the results of testing

[jira] [Updated] (ZOOKEEPER-107) Allow dynamic changes to server cluster membership

2012-11-28 Thread Alexander Shraer (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shraer updated ZOOKEEPER-107: --- Attachment: (was: ZOOKEEPER-107-28-NOV-ver1.patch) Allow dynamic changes

[jira] [Updated] (ZOOKEEPER-107) Allow dynamic changes to server cluster membership

2012-11-28 Thread Alexander Shraer (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shraer updated ZOOKEEPER-107: --- Attachment: ZOOKEEPER-107-28-NOV-ver2.patch Allow dynamic changes to server

ZooKeeper_branch33_solaris - Build # 366 - Failure

2012-11-28 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch33_solaris/366/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 101397 lines...] [junit] 2012-11-29

Failed: ZOOKEEPER-107 PreCommit Build #1278

2012-11-28 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-107 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1278/ ### ## LAST 60 LINES OF THE CONSOLE ###

[jira] [Commented] (ZOOKEEPER-107) Allow dynamic changes to server cluster membership

2012-11-28 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506272#comment-13506272 ] Hadoop QA commented on ZOOKEEPER-107: - -1 overall. Here are the results of testing

[jira] [Commented] (ZOOKEEPER-107) Allow dynamic changes to server cluster membership

2012-11-28 Thread Alexander Shraer (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506275#comment-13506275 ] Alexander Shraer commented on ZOOKEEPER-107: Again, all tests passed but

Re: Review Request: Dynamic reconfiguration, see https://issues.apache.org/jira/browse/ZOOKEEPER-107

2012-11-28 Thread Alexander Shraer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6707/ --- (Updated Nov. 29, 2012, 7:12 a.m.) Review request for zookeeper. Changes

[jira] [Commented] (ZOOKEEPER-107) Allow dynamic changes to server cluster membership

2012-11-28 Thread Marshall McMullen (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506277#comment-13506277 ] Marshall McMullen commented on ZOOKEEPER-107: - The core tests includes both

[jira] [Commented] (ZOOKEEPER-107) Allow dynamic changes to server cluster membership

2012-11-28 Thread Alexander Shraer (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506287#comment-13506287 ] Alexander Shraer commented on ZOOKEEPER-107: Ah, you're right. Looking at

Build failed in Jenkins: bookkeeper-trunk #826

2012-11-28 Thread Apache Jenkins Server
See https://builds.apache.org/job/bookkeeper-trunk/826/ -- Started by timer Building remotely on ubuntu5 in workspace https://builds.apache.org/job/bookkeeper-trunk/ws/ hudson.util.IOException2: remote file operation failed:

[jira] [Commented] (BOOKKEEPER-464) Provide an improved GC algorithm

2012-11-28 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505487#comment-13505487 ] Flavio Junqueira commented on BOOKKEEPER-464: - Unless I'm misunderstanding

[jira] [Resolved] (BOOKKEEPER-486) BOOKKEEPER-440 introduced 1 findbugs warning.

2012-11-28 Thread Ivan Kelly (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly resolved BOOKKEEPER-486. --- Resolution: Fixed BOOKKEEPER-440 introduced 1 findbugs warning.

[jira] [Reopened] (BOOKKEEPER-486) BOOKKEEPER-440 introduced 1 findbugs warning.

2012-11-28 Thread Ivan Kelly (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly reopened BOOKKEEPER-486: --- BOOKKEEPER-440 introduced 1 findbugs warning.

[jira] [Resolved] (BOOKKEEPER-486) BOOKKEEPER-440 introduced 1 findbugs warning.

2012-11-28 Thread Ivan Kelly (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly resolved BOOKKEEPER-486. --- Resolution: Duplicate BOOKKEEPER-440 introduced 1 findbugs warning.

[jira] [Commented] (BOOKKEEPER-464) Provide an improved GC algorithm

2012-11-28 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505739#comment-13505739 ] Sijie Guo commented on BOOKKEEPER-464: -- {quote} If a bookie starts replicating a

[jira] [Commented] (BOOKKEEPER-249) Revisit garbage collection algorithm in Bookie server

2012-11-28 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505905#comment-13505905 ] Flavio Junqueira commented on BOOKKEEPER-249: - Here is a thought for

[jira] [Commented] (BOOKKEEPER-464) Provide an improved GC algorithm

2012-11-28 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505906#comment-13505906 ] Flavio Junqueira commented on BOOKKEEPER-464: - Thanks, Sijie. I added a

[jira] [Commented] (BOOKKEEPER-249) Revisit garbage collection algorithm in Bookie server

2012-11-28 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506136#comment-13506136 ] Sijie Guo commented on BOOKKEEPER-249: -- {quote} Let me give an example to

[jira] [Updated] (BOOKKEEPER-457) Create a format command for Hedwig to cleanup its metadata.

2012-11-28 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-457: - Attachment: BOOKKEEPER-457.patch Attach a new patch addressing Ivan's comments.

Re: Review Request: Refactor garbage collection code for ease to plugin different GC algorithm.

2012-11-28 Thread Fangmin Lv
On Nov. 27, 2012, 4:33 a.m., Sijie Guo wrote: great work, Fangmin. The patch looks good. Just had some minor comments, mostly about names and interface. Thanks sijie, will change the name and interface according to your comments. On Nov. 27, 2012, 4:33 a.m., Sijie Guo wrote:

Re: Review Request: Refactor garbage collection code for ease to plugin different GC algorithm.

2012-11-28 Thread Fangmin Lv
On Nov. 28, 2012, 5:28 p.m., fpj wrote: here are some minor comments about the patch. I still want to think a bit more about the high-level approach taken here, though. Thanks Flavio, I will change the comments and method name according to your proposal, if there are problems about

Re: Review Request: Refactor garbage collection code for ease to plugin different GC algorithm.

2012-11-28 Thread Fangmin Lv
On Nov. 28, 2012, 6:10 p.m., fpj wrote: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompareGarbageCollector.java, line 87 https://reviews.apache.org/r/8141/diff/3/?file=222511#file222511line87 what are the case(s) in which end would be -1? Sorry, this

Re: Review Request: Refactor garbage collection code for ease to plugin different GC algorithm.

2012-11-28 Thread Fangmin Lv
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8141/#review13817 ---

Re: Review Request: Refactor garbage collection code for ease to plugin different GC algorithm.

2012-11-28 Thread Fangmin Lv
On Nov. 27, 2012, 4:33 a.m., Sijie Guo wrote: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java, line 429 https://reviews.apache.org/r/8141/diff/3/?file=222513#file222513line429 since AbstractZkLedgerManager is an abstract class, I think an

Re: Review Request: Refactor garbage collection code for ease to plugin different GC algorithm.

2012-11-28 Thread Fangmin Lv
On Nov. 28, 2012, 6:10 p.m., fpj wrote: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java, line 103 https://reviews.apache.org/r/8141/diff/3/?file=222513#file222513line103 all the cases I've seen in this patch use ANY version, so I was

[jira] [Updated] (BOOKKEEPER-389) add documentation for message filter.

2012-11-28 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-389: - Attachment: BOOKKEEPER-389.patch Attach a patch to document message filter features.

[jira] [Commented] (BOOKKEEPER-410) Hedwig client should remove message handler while closing subscription

2012-11-28 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506255#comment-13506255 ] Sijie Guo commented on BOOKKEEPER-410: -- I think after BOOKKEEPER-70, we had

[jira] [Commented] (BOOKKEEPER-389) add documentation for message filter.

2012-11-28 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506260#comment-13506260 ] Hadoop QA commented on BOOKKEEPER-389: -- Testing JIRA BOOKKEEPER-389 WARNING:

[jira] [Commented] (BOOKKEEPER-351) asyncAddEntry should not throw an exception

2012-11-28 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506261#comment-13506261 ] Sijie Guo commented on BOOKKEEPER-351: -- [~merlimat] Is there any updates about

Re: Review Request: Refactor garbage collection code for ease to plugin different GC algorithm.

2012-11-28 Thread Fangmin Lv
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8141/ --- (Updated Nov. 29, 2012, 7:05 a.m.) Review request for bookkeeper. Changes

[jira] [Updated] (BOOKKEEPER-463) Refactor garbage collection code for ease to plugin different GC algorithm.

2012-11-28 Thread Fangmin Lv (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fangmin Lv updated BOOKKEEPER-463: -- Attachment: BOOKKEEPER-463.patch Provide a new patch according to Sijie and Flavio's

[jira] [Updated] (BOOKKEEPER-399) Let hub server could configure write quorum from ack quorum.

2012-11-28 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-399: - Attachment: BOOKKEEPER-399.diff attach a patch to let hub server could configure write