[jira] [Commented] (ZOOKEEPER-2091) Possible logic error in ClientCnxnSocketNIO

2014-12-12 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14243864#comment-14243864 ] Rakesh R commented on ZOOKEEPER-2091: - bq.I am confused how it reads the returning

ZooKeeper-trunk-ibm6 - Build # 704 - Still Failing

2014-12-12 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-ibm6/704/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 361384 lines...] [junit] 2014-12-12 09:32:18,574

ZooKeeper-trunk - Build # 2529 - Failure

2014-12-12 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/2529/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 330090 lines...] [junit] 2014-12-12 11:10:53,928

Re: Review Request 27244: ZOOKEEPER-2069

2014-12-12 Thread Rakesh R
On Dec. 11, 2014, 7:37 p.m., Rakesh R wrote: src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java, line 108 https://reviews.apache.org/r/27244/diff/28/?file=789550#file789550line108 bootstrap.setOption(connectTimeoutMillis, System.getProperty(connectTimeoutMillis));

ZooKeeper_branch35_jdk7 - Build # 139 - Still Failing

2014-12-12 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/139/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 336860 lines...] [exec] mv -f

[jira] [Commented] (ZOOKEEPER-2091) Possible logic error in ClientCnxnSocketNIO

2014-12-12 Thread Hongchao Deng (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14244534#comment-14244534 ] Hongchao Deng commented on ZOOKEEPER-2091: -- Did you try only loop writing in

Re: Review Request 27244: ZOOKEEPER-2069

2014-12-12 Thread Hongchao Deng
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27244/ --- (Updated Dec. 12, 2014, 7:16 p.m.) Review request for zookeeper. Repository:

[jira] [Commented] (ZOOKEEPER-2091) Possible logic error in ClientCnxnSocketNIO

2014-12-12 Thread Camille Fournier (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14244659#comment-14244659 ] Camille Fournier commented on ZOOKEEPER-2091: - I agree that it seems like

[jira] [Commented] (ZOOKEEPER-2091) Possible logic error in ClientCnxnSocketNIO

2014-12-12 Thread Hongchao Deng (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14244672#comment-14244672 ] Hongchao Deng commented on ZOOKEEPER-2091: -- bq. then allow another read to

ZooKeeper-trunk-openjdk7 - Build # 658 - Failure

2014-12-12 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/658/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 329349 lines...] [junit] 2014-12-12

Make JDK 7 the minimum support version

2014-12-12 Thread Hongchao Deng
Hi all, I have been working on Netty + SSL and one of the changes I do is change outgoingQueue to be LinkedBlockingDeque, which requires JDK 6. As Flavio (fpj) and Patrick (phunt) suggested, there are JIRAs discussing JDK7: ZOOKEEPER-2046, ZOOKEEPER-1963. It seems many people are interested in

[jira] [Commented] (ZOOKEEPER-2091) Possible logic error in ClientCnxnSocketNIO

2014-12-12 Thread Camille Fournier (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14244861#comment-14244861 ] Camille Fournier commented on ZOOKEEPER-2091: - I'm all the way in the

[jira] [Commented] (ZOOKEEPER-2091) Possible logic error in ClientCnxnSocketNIO

2014-12-12 Thread Hongchao Deng (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14244878#comment-14244878 ] Hongchao Deng commented on ZOOKEEPER-2091: -- Thanks [~fournc] for the in-depth

[jira] [Commented] (ZOOKEEPER-2091) Possible logic error in ClientCnxnSocketNIO

2014-12-12 Thread Camille Fournier (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14244892#comment-14244892 ] Camille Fournier commented on ZOOKEEPER-2091: - I agree [~hdeng] but I'm

Re: Review Request 27244: ZOOKEEPER-2069

2014-12-12 Thread fpj
On Dec. 11, 2014, 11:16 p.m., fpj wrote: src/java/main/org/apache/zookeeper/ClientCnxn.java, line 1472 https://reviews.apache.org/r/27244/diff/28/?file=789547#file789547line1472 I'm now confused by this change. Are you getting rid of enableWrite? saslCompleted is fairly different

Re: Review Request 27244: ZOOKEEPER-2069

2014-12-12 Thread Hongchao Deng
On Dec. 11, 2014, 11:16 p.m., fpj wrote: src/java/main/org/apache/zookeeper/ClientCnxn.java, line 134 https://reviews.apache.org/r/27244/diff/28/?file=789547#file789547line134 It sounds like making pendingQueue and outgoingQueue are optimizations that are independent from this

Re: Make JDK 7 the minimum support version

2014-12-12 Thread Flavio Junqueira
+1 for supporting only 7 or later. On 12 Dec 2014, at 21:28, Hongchao Deng hd...@cloudera.com wrote: Hi all, I have been working on Netty + SSL and one of the changes I do is change outgoingQueue to be LinkedBlockingDeque, which requires JDK 6. As Flavio (fpj) and Patrick (phunt)

Re: Review Request 27244: ZOOKEEPER-2069

2014-12-12 Thread fpj
On Dec. 11, 2014, 11:16 p.m., fpj wrote: src/java/main/org/apache/zookeeper/ClientCnxn.java, line 134 https://reviews.apache.org/r/27244/diff/28/?file=789547#file789547line134 It sounds like making pendingQueue and outgoingQueue are optimizations that are independent from this

Re: Make JDK 7 the minimum support version

2014-12-12 Thread Patrick Hunt
+1 Makes sense to me. I'm assuming we're talking 3.5+ here, right? We would continue to support jdk6 in 3.4? Patrick On Fri, Dec 12, 2014 at 3:42 PM, Flavio Junqueira fpjunque...@yahoo.com.invalid wrote: +1 for supporting only 7 or later. On 12 Dec 2014, at 21:28, Hongchao Deng

Re: Make JDK 7 the minimum support version

2014-12-12 Thread Camille Fournier
+1 for 3.5+ On Fri, Dec 12, 2014 at 6:53 PM, Patrick Hunt ph...@apache.org wrote: +1 Makes sense to me. I'm assuming we're talking 3.5+ here, right? We would continue to support jdk6 in 3.4? Patrick On Fri, Dec 12, 2014 at 3:42 PM, Flavio Junqueira fpjunque...@yahoo.com.invalid wrote:

Re: Review Request 27244: ZOOKEEPER-2069

2014-12-12 Thread Hongchao Deng
On Dec. 11, 2014, 11:16 p.m., fpj wrote: src/java/main/org/apache/zookeeper/ClientCnxn.java, line 134 https://reviews.apache.org/r/27244/diff/28/?file=789547#file789547line134 It sounds like making pendingQueue and outgoingQueue are optimizations that are independent from this

RE: Make JDK 7 the minimum support version

2014-12-12 Thread Hongchao Deng
Right. We are discussing on ZK 3.5+ - Hongchao Deng From: ph...@apache.org Date: Fri, 12 Dec 2014 15:53:17 -0800 Subject: Re: Make JDK 7 the minimum support version To: dev@zookeeper.apache.org CC: u...@zookeeper.apache.org +1 Makes sense to me. I'm assuming we're talking 3.5+ here,

Re: Review Request 27244: ZOOKEEPER-2069

2014-12-12 Thread Hongchao Deng
On Dec. 11, 2014, 11:16 p.m., fpj wrote: src/java/main/org/apache/zookeeper/ClientCnxn.java, line 134 https://reviews.apache.org/r/27244/diff/28/?file=789547#file789547line134 It sounds like making pendingQueue and outgoingQueue are optimizations that are independent from this

[jira] [Commented] (ZOOKEEPER-2091) Possible logic error in ClientCnxnSocketNIO

2014-12-12 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245244#comment-14245244 ] Rakesh R commented on ZOOKEEPER-2091: - bq.Did you try only loop writing in