Re: Review Request 33713: ZOOKEEPER-2163 - Complete implementation and doc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33713/ --- (Updated May 30, 2015, 12:19 a.m.) Review request for zookeeper, michim, Rakesh

Re: Review Request 33713: ZOOKEEPER-2163 - Complete implementation and doc

> On May 29, 2015, 11:56 p.m., Raul Gutierrez Segales wrote: > > src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java, line > > 467 > > > > > > why was this check added ooi? I think it's a bad merge. I

Re: Review Request 33713: ZOOKEEPER-2163 - Complete implementation and doc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33713/#review85841 --- src/java/main/org/apache/zookeeper/CreateMode.java

[jira] [Commented] (ZOOKEEPER-2163) Introduce new ZNode type: container

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565661#comment-14565661 ] Hadoop QA commented on ZOOKEEPER-2163: -- +1 overall. Here are the results of test

Success: ZOOKEEPER-2163 PreCommit Build #2723

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2163 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2723/ ### ## LAST 60 LINES OF THE CONSOLE ### [

Re: Review Request 33713: ZOOKEEPER-2163 - Complete implementation and doc

> On May 29, 2015, 8:26 p.m., Raul Gutierrez Segales wrote: > > src/zookeeper.jute, line 268 > > > > > > why do we need this? can't we not just use CreateTxn and differentiate > > on opcode (as w/ do with CreateReques

Re: Review Request 33713: ZOOKEEPER-2163 - Complete implementation and doc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33713/ --- (Updated May 29, 2015, 11:01 p.m.) Review request for zookeeper, michim, Rakesh

[jira] [Commented] (ZOOKEEPER-2163) Introduce new ZNode type: container

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565600#comment-14565600 ] Raul Gutierrez Segales commented on ZOOKEEPER-2163: --- A note for othe

Failed: ZOOKEEPER-ZOOKEEPER-2163 PreCommit Build #2722

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-ZOOKEEPER-2163 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2722/ ### ## LAST 60 LINES OF THE CONSOLE ###

[jira] [Commented] (ZOOKEEPER-2163) Introduce new ZNode type: container

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565586#comment-14565586 ] Raul Gutierrez Segales commented on ZOOKEEPER-2163: --- i think so, i'v

[jira] [Commented] (ZOOKEEPER-2163) Introduce new ZNode type: container

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565549#comment-14565549 ] Jordan Zimmerman commented on ZOOKEEPER-2163: - org.apache.zookeeper.test.R

[jira] [Commented] (ZOOKEEPER-2163) Introduce new ZNode type: container

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565550#comment-14565550 ] Jordan Zimmerman commented on ZOOKEEPER-2163: - org.apache.zookeeper.test.R

[jira] [Commented] (ZOOKEEPER-2163) Introduce new ZNode type: container

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565535#comment-14565535 ] Hadoop QA commented on ZOOKEEPER-2163: -- -1 overall. Here are the results of test

Failed: ZOOKEEPER-2163 PreCommit Build #2721

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2163 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2721/ ### ## LAST 60 LINES OF THE CONSOLE ### [

[jira] [Commented] (ZOOKEEPER-2098) QuorumCnxManager: use BufferedOutputStream for initial msg

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565484#comment-14565484 ] Hongchao Deng commented on ZOOKEEPER-2098: -- Committed: trunk: https://github

[jira] [Updated] (ZOOKEEPER-2098) QuorumCnxManager: use BufferedOutputStream for initial msg

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongchao Deng updated ZOOKEEPER-2098: - Fix Version/s: (was: 3.5.2) 3.5.1 > QuorumCnxManager: use Buffe

[jira] [Updated] (ZOOKEEPER-2163) Introduce new ZNode type: container

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman updated ZOOKEEPER-2163: Attachment: zookeeper-2163.10.patch Removed bad import > Introduce new ZNode ty

Re: Review Request 33713: ZOOKEEPER-2163 - Complete implementation and doc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33713/#review85796 --- src/java/main/org/apache/zookeeper/ZooKeeper.java

[jira] [Commented] (ZOOKEEPER-2098) QuorumCnxManager: use BufferedOutputStream for initial msg

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565337#comment-14565337 ] Hongchao Deng commented on ZOOKEEPER-2098: -- +1, LGTM. Thanks [~rgs], I will

[jira] [Commented] (ZOOKEEPER-2163) Introduce new ZNode type: container

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565334#comment-14565334 ] Hadoop QA commented on ZOOKEEPER-2163: -- -1 overall. Here are the results of test

Failed: ZOOKEEPER-2163 PreCommit Build #2720

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2163 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2720/ ### ## LAST 60 LINES OF THE CONSOLE ### [

[jira] [Commented] (ZOOKEEPER-2098) QuorumCnxManager: use BufferedOutputStream for initial msg

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565322#comment-14565322 ] Hadoop QA commented on ZOOKEEPER-2098: -- -1 overall. Here are the results of test

Failed: ZOOKEEPER-2098 PreCommit Build #2719

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2098 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2719/ ### ## LAST 60 LINES OF THE CONSOLE ### [

ZooKeeper-trunk-openjdk7 - Build # 825 - Failure

See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/825/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 372560 lines...] [junit] 2015-05-29 20:10:08,44

[jira] [Updated] (ZOOKEEPER-2163) Introduce new ZNode type: container

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman updated ZOOKEEPER-2163: Attachment: zookeeper-2163.9.patch Rebase against latest trunk and consolidate n

Re: Review Request 33713: ZOOKEEPER-2163 - Complete implementation and doc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33713/ --- (Updated May 29, 2015, 8:03 p.m.) Review request for zookeeper, michim, Rakesh

Re: Review Request 33713: ZOOKEEPER-2163 - Complete implementation and doc

> On May 29, 2015, 5:16 p.m., Raul Gutierrez Segales wrote: > > src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java, line > > 553 > > > > > > hmm, can't we not handle createContainer and deleteContaine

[jira] [Updated] (ZOOKEEPER-2179) Typo in Watcher.java

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-2179: -- Fix Version/s: (was: 3.4.5) 3.6.0

[jira] [Commented] (ZOOKEEPER-1748) TCP keepalive for leader election connections

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565272#comment-14565272 ] Raul Gutierrez Segales commented on ZOOKEEPER-1748: --- Sorry for the s

[jira] [Updated] (ZOOKEEPER-1748) TCP keepalive for leader election connections

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-1748: -- Assignee: Daniel Peon > TCP keepalive for leader election connection

[jira] [Updated] (ZOOKEEPER-1748) TCP keepalive for leader election connections

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-1748: -- Assignee: (was: Daniel Peon) > TCP keepalive for leader election

[jira] [Commented] (ZOOKEEPER-832) Invalid session id causes infinite loop during automatic reconnect

[ https://issues.apache.org/jira/browse/ZOOKEEPER-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565249#comment-14565249 ] Raul Gutierrez Segales commented on ZOOKEEPER-832: -- does it fail consi

[jira] [Updated] (ZOOKEEPER-2098) QuorumCnxManager: use BufferedOutputStream for initial msg

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-2098: -- Attachment: ZOOKEEPER-2098.patch sorry for the slow return, this add

Re: Review Request 33713: ZOOKEEPER-2163 - Complete implementation and doc

> On May 29, 2015, 5:16 p.m., Raul Gutierrez Segales wrote: > > src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java, line > > 553 > > > > > > hmm, can't we not handle createContainer and deleteContaine

Re: Review Request 33713: ZOOKEEPER-2163 - Complete implementation and doc

> On May 29, 2015, 5:16 p.m., Raul Gutierrez Segales wrote: > > src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java, line > > 553 > > > > > > hmm, can't we not handle createContainer and deleteContaine

[jira] [Commented] (ZOOKEEPER-2187) remove duplicated code between CreateRequest{,2}

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565131#comment-14565131 ] Hongchao Deng commented on ZOOKEEPER-2187: -- Commited. trunk: https://github.

[jira] [Updated] (ZOOKEEPER-2187) remove duplicated code between CreateRequest{,2}

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongchao Deng updated ZOOKEEPER-2187: - Release Note: (was: trunk: https://github.com/apache/zookeeper/commit/652a53618cf9316

[jira] [Updated] (ZOOKEEPER-2187) remove duplicated code between CreateRequest{,2}

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongchao Deng updated ZOOKEEPER-2187: - Fix Version/s: (was: 3.5.2) 3.5.1 > remove duplicated code betw

[jira] [Commented] (ZOOKEEPER-2187) remove duplicated code between CreateRequest{,2}

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565115#comment-14565115 ] Hongchao Deng commented on ZOOKEEPER-2187: -- +1, Thanks [~rgs]. I will commit

[jira] [Commented] (ZOOKEEPER-2187) remove duplicated code between CreateRequest{,2}

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565097#comment-14565097 ] Raul Gutierrez Segales commented on ZOOKEEPER-2187: --- [~rakeshr], [~h

[jira] [Commented] (ZOOKEEPER-2163) Introduce new ZNode type: container

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565093#comment-14565093 ] Raul Gutierrez Segales commented on ZOOKEEPER-2163: --- mostly happy wi

Re: Review Request 33713: ZOOKEEPER-2163 - Complete implementation and doc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33713/#review85752 --- src/java/main/org/apache/zookeeper/CreateMode.java

[jira] [Commented] (ZOOKEEPER-832) Invalid session id causes infinite loop during automatic reconnect

[ https://issues.apache.org/jira/browse/ZOOKEEPER-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564728#comment-14564728 ] Germán Blanco commented on ZOOKEEPER-832: - testCurrentObserverIsParticipantInNe

ZooKeeper-trunk-jdk8 - Build # 397 - Failure

See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/397/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 1493 lines...] [javacc] File "Token.java" does not e

[jira] [Commented] (ZOOKEEPER-1748) TCP keepalive for leader election connections

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564681#comment-14564681 ] Guillaume Drot commented on ZOOKEEPER-1748: --- Can you give us an update on th

ZooKeeper_branch34_openjdk7 - Build # 891 - Failure

See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/891/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 211572 lines...] [junit] 2015-05-29 11:35:13

Failed: ZOOKEEPER-832 PreCommit Build #2718

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-832 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2718/ ### ## LAST 60 LINES OF THE CONSOLE ### [.

[jira] [Commented] (ZOOKEEPER-832) Invalid session id causes infinite loop during automatic reconnect

[ https://issues.apache.org/jira/browse/ZOOKEEPER-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564362#comment-14564362 ] Hadoop QA commented on ZOOKEEPER-832: - -1 overall. Here are the results of testing

[jira] [Commented] (ZOOKEEPER-2172) Cluster crashes when reconfig a new node as a participant

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564347#comment-14564347 ] Ziyou Wang commented on ZOOKEEPER-2172: --- No, they are in totally independent doc

[jira] [Updated] (ZOOKEEPER-832) Invalid session id causes infinite loop during automatic reconnect

[ https://issues.apache.org/jira/browse/ZOOKEEPER-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Germán Blanco updated ZOOKEEPER-832: Attachment: ZOOKEEPER-832.patch Adding a check for the initialization of the ZkDatabase