ZooKeeper-trunk - Build # 3137 - Still Failing

2016-10-29 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/3137/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 427549 lines...] [junit] at

[jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins

2016-10-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15618788#comment-15618788 ] ASF GitHub Bot commented on ZOOKEEPER-1525: --- Github user Randgalt commented on the issue:

[GitHub] zookeeper issue #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object into auth...

2016-10-29 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/84 @fpj I've addressed and pushed changes for all your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins

2016-10-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15618785#comment-15618785 ] ASF GitHub Bot commented on ZOOKEEPER-1525: --- Github user Randgalt commented on a diff in the

[jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins

2016-10-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15618783#comment-15618783 ] ASF GitHub Bot commented on ZOOKEEPER-1525: --- Github user Randgalt commented on a diff in the

[GitHub] zookeeper pull request #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object in...

2016-10-29 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/84#discussion_r85649028 --- Diff: src/java/main/org/apache/zookeeper/server/auth/ProviderRegistry.java --- @@ -31,7 +31,15 @@ private static boolean initialized =

[GitHub] zookeeper pull request #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object in...

2016-10-29 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/84#discussion_r85649005 --- Diff: src/java/test/org/apache/zookeeper/test/KeyAuthClientTest.java --- @@ -0,0 +1,131 @@ +/** + * Licensed to the Apache Software Foundation

[jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins

2016-10-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15618780#comment-15618780 ] ASF GitHub Bot commented on ZOOKEEPER-1525: --- Github user Randgalt commented on a diff in the

[GitHub] zookeeper pull request #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object in...

2016-10-29 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/84#discussion_r85648967 --- Diff: src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml --- @@ -1193,6 +1193,55 @@ authProvider.2=com.f.MyAuth2 only one will

[jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins

2016-10-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15618776#comment-15618776 ] ASF GitHub Bot commented on ZOOKEEPER-1525: --- Github user Randgalt commented on a diff in the

ZooKeeper-trunk-openjdk7 - Build # 1220 - Still Failing

2016-10-29 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1220/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 429185 lines...] [junit] 2016-10-29

$PROJECT_NAME - Build # $BUILD_NUMBER - $BUILD_STATUS

2016-10-29 Thread Apache Jenkins Server
See ${BUILD_URL} ### ## LAST 60 LINES OF THE CONSOLE ### ${BUILD_LOG, maxLines=60} ###

Re: QA github pre-commit queue

2016-10-29 Thread Flavio Junqueira
Another thing I forgot to mention and I noticed we are missing is to make a jira patch available when a pull request is submitted and cancel the patch if the pull request is closed without merging. I think there is a way of doing it. It should also be possible to resolve the jira automatically

[jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins

2016-10-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15618278#comment-15618278 ] ASF GitHub Bot commented on ZOOKEEPER-1525: --- Github user fpj commented on the issue:

[jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins

2016-10-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15618270#comment-15618270 ] ASF GitHub Bot commented on ZOOKEEPER-1525: --- Github user fpj commented on a diff in the pull

[jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins

2016-10-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15618277#comment-15618277 ] ASF GitHub Bot commented on ZOOKEEPER-1525: --- Github user fpj commented on a diff in the pull

[GitHub] zookeeper pull request #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object in...

2016-10-29 Thread fpj
Github user fpj commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/84#discussion_r85642051 --- Diff: src/java/test/org/apache/zookeeper/test/KeyAuthClientTest.java --- @@ -0,0 +1,131 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins

2016-10-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15618275#comment-15618275 ] ASF GitHub Bot commented on ZOOKEEPER-1525: --- Github user fpj commented on a diff in the pull

[GitHub] zookeeper pull request #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object in...

2016-10-29 Thread fpj
Github user fpj commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/84#discussion_r85642282 --- Diff: src/java/main/org/apache/zookeeper/server/auth/ServerAuthenticationProvider.java --- @@ -0,0 +1,79 @@ +/** + * Licensed to the Apache

[jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins

2016-10-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15618268#comment-15618268 ] ASF GitHub Bot commented on ZOOKEEPER-1525: --- Github user fpj commented on a diff in the pull

[GitHub] zookeeper pull request #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object in...

2016-10-29 Thread fpj
Github user fpj commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/84#discussion_r85642202 --- Diff: src/java/test/org/apache/zookeeper/test/KeyAuthClientTest.java --- @@ -0,0 +1,131 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins

2016-10-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15618269#comment-15618269 ] ASF GitHub Bot commented on ZOOKEEPER-1525: --- Github user fpj commented on a diff in the pull

[jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins

2016-10-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15618271#comment-15618271 ] ASF GitHub Bot commented on ZOOKEEPER-1525: --- Github user fpj commented on a diff in the pull

[GitHub] zookeeper issue #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object into auth...

2016-10-29 Thread fpj
Github user fpj commented on the issue: https://github.com/apache/zookeeper/pull/84 @Randgalt My comments are pretty minor, but it will give it a chance to QA to test this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins

2016-10-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15618272#comment-15618272 ] ASF GitHub Bot commented on ZOOKEEPER-1525: --- Github user fpj commented on a diff in the pull

[jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins

2016-10-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15618273#comment-15618273 ] ASF GitHub Bot commented on ZOOKEEPER-1525: --- Github user fpj commented on a diff in the pull

[GitHub] zookeeper pull request #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object in...

2016-10-29 Thread fpj
Github user fpj commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/84#discussion_r85642270 --- Diff: src/java/main/org/apache/zookeeper/server/auth/ProviderRegistry.java --- @@ -31,7 +31,15 @@ private static boolean initialized =

[GitHub] zookeeper pull request #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object in...

2016-10-29 Thread fpj
Github user fpj commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/84#discussion_r85641947 --- Diff: src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml --- @@ -1193,6 +1193,55 @@ authProvider.2=com.f.MyAuth2 only one will be

[GitHub] zookeeper pull request #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object in...

2016-10-29 Thread fpj
Github user fpj commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/84#discussion_r85642186 --- Diff: src/java/test/org/apache/zookeeper/test/KeyAuthClientTest.java --- @@ -0,0 +1,131 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins

2016-10-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15618274#comment-15618274 ] ASF GitHub Bot commented on ZOOKEEPER-1525: --- Github user fpj commented on a diff in the pull

[GitHub] zookeeper pull request #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object in...

2016-10-29 Thread fpj
Github user fpj commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/84#discussion_r85641968 --- Diff: src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java --- @@ -543,7 +546,7 @@ protected void pRequest2Txn(int type, long zxid, Request

[GitHub] zookeeper pull request #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object in...

2016-10-29 Thread fpj
Github user fpj commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/84#discussion_r85641975 --- Diff: src/java/main/org/apache/zookeeper/server/ServerCnxn.java --- @@ -51,7 +47,7 @@ final public static Object me = new Object();

[GitHub] zookeeper pull request #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object in...

2016-10-29 Thread fpj
Github user fpj commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/84#discussion_r85642389 --- Diff: src/java/main/org/apache/zookeeper/server/auth/WrappedAuthenticationProvider.java --- @@ -0,0 +1,74 @@ +/** + * Licensed to the Apache

[jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins

2016-10-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15618276#comment-15618276 ] ASF GitHub Bot commented on ZOOKEEPER-1525: --- Github user fpj commented on a diff in the pull

[GitHub] zookeeper pull request #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object in...

2016-10-29 Thread fpj
Github user fpj commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/84#discussion_r85642046 --- Diff: src/java/test/org/apache/zookeeper/test/KeyAuthClientTest.java --- @@ -0,0 +1,131 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

ZooKeeper_branch34_solaris - Build # 1341 - Failure

2016-10-29 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_solaris/1341/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 3315 lines...] [junit] 2016-10-29

ZooKeeper-trunk-jdk8 - Build # 800 - Still Failing

2016-10-29 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/800/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 427066 lines...] [junit] 2016-10-29 12:00:43,262

ZooKeeper_branch35_openjdk7 - Build # 280 - Still Failing

2016-10-29 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_openjdk7/280/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 425321 lines...] [junit] at

[jira] [Updated] (ZOOKEEPER-2346) SASL Auth failure manifested to client as connection refusal

2016-10-29 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Junqueira updated ZOOKEEPER-2346: Assignee: Meyer Kizner > SASL Auth failure manifested to client as connection

[jira] [Commented] (ZOOKEEPER-1394) ClassNotFoundException on shutdown of client

2016-10-29 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15617816#comment-15617816 ] Flavio Junqueira commented on ZOOKEEPER-1394: - Hi [~wuwen], If we agree that it isn't an

ZooKeeper_branch35_jdk7 - Build # 715 - Failure

2016-10-29 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/715/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 404590 lines...] [junit] at

[jira] [Commented] (ZOOKEEPER-1394) ClassNotFoundException on shutdown of client

2016-10-29 Thread wu wen (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15617726#comment-15617726 ] wu wen commented on ZOOKEEPER-1394: --- Hi [~fpj], I start to agree that this is not a problem, the

ZooKeeper-trunk-solaris - Build # 1365 - Still Failing

2016-10-29 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-solaris/1365/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 438316 lines...] [junit] 2016-10-29