[GitHub] zookeeper issue #229: ZOOKEEPER-2759: Flaky test: org.apache.zookeeper.serve...

2017-04-26 Thread afine
Github user afine commented on the issue: https://github.com/apache/zookeeper/pull/229 @hanm thank you for the through review. you are right the original test is bogus. I wanted to write the test in a way that verifies behavior for both peers so I used mockito to spy on the s

[jira] [Commented] (ZOOKEEPER-2759) Flaky test: org.apache.zookeeper.server.quorum.QuorumCnxManagerTest.testNoAuthLearnerConnectToAuthRequiredServerWithHigherSid

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985967#comment-15985967 ] ASF GitHub Bot commented on ZOOKEEPER-2759: --- Github user afine commented on

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

2017-04-26 Thread Edward Ribeiro (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985814#comment-15985814 ] Edward Ribeiro commented on ZOOKEEPER-2662: --- Hey [~ckulkarni], I didn't have

[jira] [Updated] (ZOOKEEPER-2662) Export a metric for txn log sync times

2017-04-26 Thread Edward Ribeiro (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated ZOOKEEPER-2662: -- Fix Version/s: 3.6.0 > Export a metric for txn log sync times >

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985788#comment-15985788 ] ASF GitHub Bot commented on ZOOKEEPER-2662: --- GitHub user eribeiro opened a p

[GitHub] zookeeper pull request #241: ZOOKEEPER-2662: Export a metric for txn log syn...

2017-04-26 Thread eribeiro
GitHub user eribeiro opened a pull request: https://github.com/apache/zookeeper/pull/241 ZOOKEEPER-2662: Export a metric for txn log sync times You can merge this pull request into a Git repository by running: $ git pull https://github.com/eribeiro/zookeeper ZOOKEEPER-2662 Al

[jira] [Commented] (ZOOKEEPER-2755) Allow to subclass ClientCnxnSocketNetty and NettyServerCnxn in order to use Netty Local transport

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985779#comment-15985779 ] ASF GitHub Bot commented on ZOOKEEPER-2755: --- Github user afine commented on

[GitHub] zookeeper pull request #227: ZOOKEEPER-2755 Allow to subclass ClientCnxnSock...

2017-04-26 Thread afine
Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/227#discussion_r113590962 --- Diff: src/java/test/org/apache/zookeeper/test/NettyLocalSuiteTest.java --- @@ -0,0 +1,35 @@ +/** + * Licensed to the Apache Software Foundation

[jira] [Commented] (ZOOKEEPER-2697) Handle graceful stop of ZookKeeper client

2017-04-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985759#comment-15985759 ] Hadoop QA commented on ZOOKEEPER-2697: -- -1 overall. GitHub Pull Request Build

Failed: ZOOKEEPER- PreCommit Build #641

2017-04-26 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/641/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 69.33 MB...] [exec] [exec]

Success: ZOOKEEPER- PreCommit Build #640

2017-04-26 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/640/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 69.78 MB...] [exec] [exec]

[jira] [Commented] (ZOOKEEPER-2755) Allow to subclass ClientCnxnSocketNetty and NettyServerCnxn in order to use Netty Local transport

2017-04-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985630#comment-15985630 ] Hadoop QA commented on ZOOKEEPER-2755: -- +1 overall. GitHub Pull Request Build

Failed: ZOOKEEPER- PreCommit Build #638

2017-04-26 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/638/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 31.72 KB...] [exec] [exec]

Failed: ZOOKEEPER- PreCommit Build #639

2017-04-26 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/639/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 32.34 KB...] [exec] +1 javad

[jira] [Commented] (ZOOKEEPER-2755) Allow to subclass ClientCnxnSocketNetty and NettyServerCnxn in order to use Netty Local transport

2017-04-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985097#comment-15985097 ] Hadoop QA commented on ZOOKEEPER-2755: -- -1 overall. GitHub Pull Request Build

[jira] [Commented] (ZOOKEEPER-2697) Handle graceful stop of ZookKeeper client

2017-04-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985098#comment-15985098 ] Hadoop QA commented on ZOOKEEPER-2697: -- -1 overall. GitHub Pull Request Build

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

2017-04-26 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985094#comment-15985094 ] Andrew Purtell commented on ZOOKEEPER-2662: --- The test looks good to me [~cku

Success: ZOOKEEPER- PreCommit Build #636

2017-04-26 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/636/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 69.73 MB...] [exec] [exec]

[jira] [Commented] (ZOOKEEPER-2755) Allow to subclass ClientCnxnSocketNetty and NettyServerCnxn in order to use Netty Local transport

2017-04-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984736#comment-15984736 ] Hadoop QA commented on ZOOKEEPER-2755: -- +1 overall. GitHub Pull Request Build

[jira] [Commented] (ZOOKEEPER-2697) Handle graceful stop of ZookKeeper client

2017-04-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984735#comment-15984735 ] Hadoop QA commented on ZOOKEEPER-2697: -- +1 overall. GitHub Pull Request Build

Success: ZOOKEEPER- PreCommit Build #637

2017-04-26 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/637/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 68.65 MB...] [exec] [exec]

[GitHub] zookeeper issue #222: ZOOKEEPER-2697 Handle graceful stop of ZookKeeper clie...

2017-04-26 Thread eolivelli
Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/222 @hanm This patch only adds a new method, with no changes to the rest of the library and it does not break binary compatibility. So IMHO It can be safely added to 3.5.x branch to. But I am a n

[jira] [Commented] (ZOOKEEPER-2697) Handle graceful stop of ZookKeeper client

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984535#comment-15984535 ] ASF GitHub Bot commented on ZOOKEEPER-2697: --- Github user eolivelli commented

[jira] [Commented] (ZOOKEEPER-2697) Handle graceful stop of ZookKeeper client

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984532#comment-15984532 ] ASF GitHub Bot commented on ZOOKEEPER-2697: --- Github user eolivelli commented

[GitHub] zookeeper pull request #222: ZOOKEEPER-2697 Handle graceful stop of ZookKeep...

2017-04-26 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/222#discussion_r113415006 --- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java --- @@ -1325,6 +1325,23 @@ public synchronized void close() throws InterruptedException {

[jira] [Commented] (ZOOKEEPER-2697) Handle graceful stop of ZookKeeper client

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984530#comment-15984530 ] ASF GitHub Bot commented on ZOOKEEPER-2697: --- Github user eolivelli commented

[GitHub] zookeeper pull request #222: ZOOKEEPER-2697 Handle graceful stop of ZookKeep...

2017-04-26 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/222#discussion_r113414762 --- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java --- @@ -1325,6 +1325,23 @@ public synchronized void close() throws InterruptedException {

[jira] [Commented] (ZOOKEEPER-2755) Allow to subclass ClientCnxnSocketNetty and NettyServerCnxn in order to use Netty Local transport

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984527#comment-15984527 ] ASF GitHub Bot commented on ZOOKEEPER-2755: --- Github user eolivelli commented

[GitHub] zookeeper pull request #227: ZOOKEEPER-2755 Allow to subclass ClientCnxnSock...

2017-04-26 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/227#discussion_r113414288 --- Diff: src/java/test/org/apache/zookeeper/test/NettyLocalSuiteTest.java --- @@ -0,0 +1,35 @@ +/** + * Licensed to the Apache Software Foundat

[jira] [Commented] (ZOOKEEPER-2763) Utils.toCsvBuffer() omits leading 0 for bytes < 0x10

2017-04-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984319#comment-15984319 ] Hadoop QA commented on ZOOKEEPER-2763: -- -1 overall. GitHub Pull Request Build

Failed: ZOOKEEPER- PreCommit Build #635

2017-04-26 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/635/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 68.00 MB...] [exec] [exec]