Github user afine commented on the issue:
https://github.com/apache/zookeeper/pull/229
@hanm thank you for the through review. you are right the original test is
bogus.
I wanted to write the test in a way that verifies behavior for both peers
so I used mockito to spy on the s
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985967#comment-15985967
]
ASF GitHub Bot commented on ZOOKEEPER-2759:
---
Github user afine commented on
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985814#comment-15985814
]
Edward Ribeiro commented on ZOOKEEPER-2662:
---
Hey [~ckulkarni], I didn't have
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Edward Ribeiro updated ZOOKEEPER-2662:
--
Fix Version/s: 3.6.0
> Export a metric for txn log sync times
>
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985788#comment-15985788
]
ASF GitHub Bot commented on ZOOKEEPER-2662:
---
GitHub user eribeiro opened a p
GitHub user eribeiro opened a pull request:
https://github.com/apache/zookeeper/pull/241
ZOOKEEPER-2662: Export a metric for txn log sync times
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eribeiro/zookeeper ZOOKEEPER-2662
Al
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985779#comment-15985779
]
ASF GitHub Bot commented on ZOOKEEPER-2755:
---
Github user afine commented on
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/227#discussion_r113590962
--- Diff: src/java/test/org/apache/zookeeper/test/NettyLocalSuiteTest.java
---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache Software Foundation
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985759#comment-15985759
]
Hadoop QA commented on ZOOKEEPER-2697:
--
-1 overall. GitHub Pull Request Build
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/641/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 69.33 MB...]
[exec]
[exec]
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/640/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 69.78 MB...]
[exec]
[exec]
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985630#comment-15985630
]
Hadoop QA commented on ZOOKEEPER-2755:
--
+1 overall. GitHub Pull Request Build
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/638/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 31.72 KB...]
[exec]
[exec]
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/639/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 32.34 KB...]
[exec] +1 javad
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985097#comment-15985097
]
Hadoop QA commented on ZOOKEEPER-2755:
--
-1 overall. GitHub Pull Request Build
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985098#comment-15985098
]
Hadoop QA commented on ZOOKEEPER-2697:
--
-1 overall. GitHub Pull Request Build
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985094#comment-15985094
]
Andrew Purtell commented on ZOOKEEPER-2662:
---
The test looks good to me [~cku
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/636/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 69.73 MB...]
[exec]
[exec]
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984736#comment-15984736
]
Hadoop QA commented on ZOOKEEPER-2755:
--
+1 overall. GitHub Pull Request Build
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984735#comment-15984735
]
Hadoop QA commented on ZOOKEEPER-2697:
--
+1 overall. GitHub Pull Request Build
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/637/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 68.65 MB...]
[exec]
[exec]
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/222
@hanm This patch only adds a new method, with no changes to the rest of the
library and it does not break binary compatibility.
So IMHO It can be safely added to 3.5.x branch to. But I am a n
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984535#comment-15984535
]
ASF GitHub Bot commented on ZOOKEEPER-2697:
---
Github user eolivelli commented
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984532#comment-15984532
]
ASF GitHub Bot commented on ZOOKEEPER-2697:
---
Github user eolivelli commented
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/222#discussion_r113415006
--- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
@@ -1325,6 +1325,23 @@ public synchronized void close() throws
InterruptedException {
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984530#comment-15984530
]
ASF GitHub Bot commented on ZOOKEEPER-2697:
---
Github user eolivelli commented
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/222#discussion_r113414762
--- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
@@ -1325,6 +1325,23 @@ public synchronized void close() throws
InterruptedException {
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984527#comment-15984527
]
ASF GitHub Bot commented on ZOOKEEPER-2755:
---
Github user eolivelli commented
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/227#discussion_r113414288
--- Diff: src/java/test/org/apache/zookeeper/test/NettyLocalSuiteTest.java
---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache Software Foundat
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984319#comment-15984319
]
Hadoop QA commented on ZOOKEEPER-2763:
--
-1 overall. GitHub Pull Request Build
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/635/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 68.00 MB...]
[exec]
[exec]
31 matches
Mail list logo