[jira] [Commented] (ZOOKEEPER-2905) Don't include `config.h` in `zookeeper.h`

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179949#comment-16179949 ] Hadoop QA commented on ZOOKEEPER-2905: -- -1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #1043

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1043/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 33.69 MB...] [exec] +0

ZooKeeper-trunk - Build # 3548 - Failure

See https://builds.apache.org/job/ZooKeeper-trunk/3548/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 65.60 MB...] [junit] 2017-09-25 23:26:32,730

Success: ZOOKEEPER- PreCommit Build #1044

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1044/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 75.65 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-2905) Don't include `config.h` in `zookeeper.h`

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179946#comment-16179946 ] Hadoop QA commented on ZOOKEEPER-2905: -- +1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-2905) Don't include `config.h` in `zookeeper.h`

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179936#comment-16179936 ] Hadoop QA commented on ZOOKEEPER-2905: -- -1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #1045

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1045/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 1.65 MB...] [exec] +0

[jira] [Commented] (ZOOKEEPER-2905) Don't include `config.h` in `zookeeper.h`

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179922#comment-16179922 ] ASF GitHub Bot commented on ZOOKEEPER-2905: --- Github user andschwa commented on the issue:

[GitHub] zookeeper issue #383: ZOOKEEPER-2905: Don't include `config.h` in `zookeeper...

Github user andschwa commented on the issue: https://github.com/apache/zookeeper/pull/383 @hanm and finally this PR is for `master`. Let me reiterate: I'm sorry! Ha, seriously, I can't believe I broke practically the same thing I was fixing. You have to be _super_ careful

[jira] [Commented] (ZOOKEEPER-2905) Don't include `config.h` in `zookeeper.h`

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179921#comment-16179921 ] ASF GitHub Bot commented on ZOOKEEPER-2905: --- GitHub user andschwa opened a pull request:

[GitHub] zookeeper pull request #383: ZOOKEEPER-2905: Don't include `config.h` in `zo...

GitHub user andschwa opened a pull request: https://github.com/apache/zookeeper/pull/383 ZOOKEEPER-2905: Don't include `config.h` in `zookeeper.h` In ZOOKEEPER-2841 I fixed the inclusion of project-specific porting code that were included in the public headers, which then broke

[jira] [Commented] (ZOOKEEPER-2905) Don't include `config.h` in `zookeeper.h`

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179919#comment-16179919 ] ASF GitHub Bot commented on ZOOKEEPER-2905: --- Github user andschwa commented on the issue:

[jira] [Commented] (ZOOKEEPER-2905) Don't include `config.h` in `zookeeper.h`

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179918#comment-16179918 ] ASF GitHub Bot commented on ZOOKEEPER-2905: --- GitHub user andschwa opened a pull request:

[GitHub] zookeeper issue #382: ZOOKEEPER-2905: Don't include `config.h` in `zookeeper...

Github user andschwa commented on the issue: https://github.com/apache/zookeeper/pull/382 @hanm and this is is for `branch-3.5`. ---

[jira] [Commented] (ZOOKEEPER-2905) Don't include `config.h` in `zookeeper.h`

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179917#comment-16179917 ] Andrew Schwartzmeyer commented on ZOOKEEPER-2905: - I didn't catch this sooner as the

[GitHub] zookeeper pull request #382: ZOOKEEPER-2905: Don't include `config.h` in `zo...

GitHub user andschwa opened a pull request: https://github.com/apache/zookeeper/pull/382 ZOOKEEPER-2905: Don't include `config.h` in `zookeeper.h` In ZOOKEEPER-2841 I fixed the inclusion of project-specific porting code that were included in the public headers, which then broke

[jira] [Commented] (ZOOKEEPER-2905) Don't include `config.h` in `zookeeper.h`

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179916#comment-16179916 ] ASF GitHub Bot commented on ZOOKEEPER-2905: --- Github user andschwa commented on the issue:

[GitHub] zookeeper issue #381: ZOOKEEPER-2905: Don't include `config.h` in `zookeeper...

Github user andschwa commented on the issue: https://github.com/apache/zookeeper/pull/381 Hey @hanm, I found and fixed a bug I made. This patches `branch-3.4`. It should be very straightforward. This is for

[jira] [Commented] (ZOOKEEPER-2905) Don't include `config.h` in `zookeeper.h`

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179912#comment-16179912 ] ASF GitHub Bot commented on ZOOKEEPER-2905: --- GitHub user andschwa opened a pull request:

[GitHub] zookeeper pull request #381: ZOOKEEPER-2905: Don't include `config.h` in `zo...

GitHub user andschwa opened a pull request: https://github.com/apache/zookeeper/pull/381 ZOOKEEPER-2905: Don't include `config.h` in `zookeeper.h` In ZOOKEEPER-2841 I fixed the inclusion of project-specific porting code that were included in the public headers, which then broke

[jira] [Updated] (ZOOKEEPER-2905) Don't include `config.h` in `zookeeper.h`

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schwartzmeyer updated ZOOKEEPER-2905: Summary: Don't include `config.h` in `zookeeper.h` (was: Don't include

[jira] [Created] (ZOOKEEPER-2905) Don't include "config.h" in public headers

Andrew Schwartzmeyer created ZOOKEEPER-2905: --- Summary: Don't include "config.h" in public headers Key: ZOOKEEPER-2905 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2905 Project:

Failed: ZOOKEEPER- PreCommit Build #1042

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1042/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 1.62 MB...] [exec]

ZooKeeper-trunk-openjdk7 - Build # 1631 - Still Failing

See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1631/ ### ## LAST 60 LINES OF THE CONSOLE ### Started by timer [EnvInject] - Loading node environment

Failed: ZOOKEEPER- PreCommit Build #1041

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1041/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 75.41 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179282#comment-16179282 ] Hadoop QA commented on ZOOKEEPER-1416: -- -1 overall. GitHub Pull Request Build +1

More Jenkins problems

https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1040/console There's some kind of ivy exception here. [exec] BUILD FAILED [exec]

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179266#comment-16179266 ] Hadoop QA commented on ZOOKEEPER-1416: -- -1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #1040

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1040/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 37.81 KB...] [exec]

Failed: ZOOKEEPER- PreCommit Build #1038

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1038/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 30.72 KB...] [exec] +1

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179248#comment-16179248 ] Hadoop QA commented on ZOOKEEPER-1416: -- -1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179249#comment-16179249 ] Hadoop QA commented on ZOOKEEPER-1416: -- -1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #1039

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1039/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 31.64 KB...] [exec]

[GitHub] zookeeper issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/136 As promised - here's the project with the benchmarking stuff: https://github.com/Randgalt/zkbench ---

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179236#comment-16179236 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user Randgalt commented on the issue:

[GitHub] zookeeper issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/136 > does the new map in the watch structure break rolling upgrades It would depend how you did it. If you upgraded all the ZK servers before adding any persistent watches you'd be OK.

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179195#comment-16179195 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user Randgalt commented on the issue:

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179190#comment-16179190 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user Randgalt commented on a diff in the

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r140815418 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -40,50 +40,110 @@ class WatchManager { private static final

ZooKeeper_branch34_openjdk7 - Build # 1657 - Failure

See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1657/ ### ## LAST 60 LINES OF THE CONSOLE ### Started by timer [EnvInject] - Loading node environment

ZooKeeper_branch35_jdk8 - Build # 681 - Failure

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/681/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 67.71 MB...] [junit] 2017-09-25 12:24:50,573

ZooKeeper-trunk-jdk8 - Build # 1213 - Still Failing

See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/1213/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 66.31 MB...] [junit] java.net.ConnectException:

ZooKeeper_branch35_openjdk7 - Build # 680 - Still Failing

See https://builds.apache.org/job/ZooKeeper_branch35_openjdk7/680/ ### ## LAST 60 LINES OF THE CONSOLE ### Started by timer [EnvInject] - Loading node environment

ZooKeeper_branch35_jdk7 - Build # 1121 - Still Failing

See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/1121/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 68.25 MB...] [junit] 2017-09-25 10:25:08,500