[jira] [Commented] (ZOOKEEPER-1580) QuorumPeer.setRunning is not used

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334873#comment-16334873 ] ASF GitHub Bot commented on ZOOKEEPER-1580: --- Github user phunt commented on a diff in the

[GitHub] zookeeper pull request #446: ZOOKEEPER-1580:QuorumPeer.setRunning is not use...

Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/446#discussion_r163063447 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java --- @@ -1751,7 +1751,7 @@ public synchronized void initConfigInZKDatabase() {

[jira] [Commented] (ZOOKEEPER-2955) Enable Clover code coverage report

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334871#comment-16334871 ] ASF GitHub Bot commented on ZOOKEEPER-2955: --- Github user phunt commented on the issue:

[GitHub] zookeeper issue #443: ZOOKEEPER-2955: Enable Clover code coverage report

Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/443 I did an "ant compile-test" and ended up with clover dependencies being pulled into build - clover dependencies should only be pulled when clover tasks are run. ---

[jira] [Commented] (ZOOKEEPER-2955) Enable Clover code coverage report

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334868#comment-16334868 ] ASF GitHub Bot commented on ZOOKEEPER-2955: --- Github user phunt commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2955) Enable Clover code coverage report

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334866#comment-16334866 ] ASF GitHub Bot commented on ZOOKEEPER-2955: --- Github user phunt commented on a diff in the

[GitHub] zookeeper pull request #443: ZOOKEEPER-2955: Enable Clover code coverage rep...

Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/443#discussion_r163062466 --- Diff: build.xml --- @@ -132,21 +169,16 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant"> - - -

[GitHub] zookeeper pull request #443: ZOOKEEPER-2955: Enable Clover code coverage rep...

Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/443#discussion_r163062338 --- Diff: build.xml --- @@ -124,6 +160,7 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant"> + --- End diff

[jira] [Commented] (ZOOKEEPER-2955) Enable Clover code coverage report

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334863#comment-16334863 ] ASF GitHub Bot commented on ZOOKEEPER-2955: --- Github user phunt commented on the issue:

[GitHub] zookeeper issue #443: ZOOKEEPER-2955: Enable Clover code coverage report

Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/443 This config (from most recent commit) is inconsistent with all the other tools, why? + ---

Success: ZOOKEEPER- PreCommit Build #1418

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1418/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 39.66 MB...] [exec]

Success: ZOOKEEPER- PreCommit Build #1417

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1417/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 77.67 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-2955) Enable Clover code coverage report

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334540#comment-16334540 ] ASF GitHub Bot commented on ZOOKEEPER-2955: --- Github user mfenes commented on the issue:

[GitHub] zookeeper issue #443: ZOOKEEPER-2955: Enable Clover code coverage report

Github user mfenes commented on the issue: https://github.com/apache/zookeeper/pull/443 @phunt I've added ivy.xml configuration for Clover: test-coverage-java and created an ant target with the same name, so generating a coverage report for Java became as simple as running ant

[jira] [Commented] (ZOOKEEPER-2955) Enable Clover code coverage report

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334533#comment-16334533 ] ASF GitHub Bot commented on ZOOKEEPER-2955: --- Github user mfenes commented on the issue:

[GitHub] zookeeper issue #443: ZOOKEEPER-2955: Enable Clover code coverage report

Github user mfenes commented on the issue: https://github.com/apache/zookeeper/pull/443 @anmolnar Clover home is now set to test.java.build.dir. No need to configure CLOVER_HOME environment variable. ---

Success: ZOOKEEPER- PreCommit Build #1416

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1416/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 77.57 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-2967) Add check to validate dataDir and dataLogDir parameters at startup

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334334#comment-16334334 ] ASF GitHub Bot commented on ZOOKEEPER-2967: --- Github user anmolnar commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2967) Add check to validate dataDir and dataLogDir parameters at startup

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334337#comment-16334337 ] ASF GitHub Bot commented on ZOOKEEPER-2967: --- Github user anmolnar commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2967) Add check to validate dataDir and dataLogDir parameters at startup

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334335#comment-16334335 ] ASF GitHub Bot commented on ZOOKEEPER-2967: --- Github user anmolnar commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2967) Add check to validate dataDir and dataLogDir parameters at startup

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334332#comment-16334332 ] ASF GitHub Bot commented on ZOOKEEPER-2967: --- Github user anmolnar commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2967) Add check to validate dataDir and dataLogDir parameters at startup

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334328#comment-16334328 ] ASF GitHub Bot commented on ZOOKEEPER-2967: --- Github user anmolnar commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2967) Add check to validate dataDir and dataLogDir parameters at startup

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334331#comment-16334331 ] ASF GitHub Bot commented on ZOOKEEPER-2967: --- Github user anmolnar commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2967) Add check to validate dataDir and dataLogDir parameters at startup

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334336#comment-16334336 ] ASF GitHub Bot commented on ZOOKEEPER-2967: --- Github user anmolnar commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2967) Add check to validate dataDir and dataLogDir parameters at startup

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334329#comment-16334329 ] ASF GitHub Bot commented on ZOOKEEPER-2967: --- Github user anmolnar commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2967) Add check to validate dataDir and dataLogDir parameters at startup

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334333#comment-16334333 ] ASF GitHub Bot commented on ZOOKEEPER-2967: --- Github user anmolnar commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2967) Add check to validate dataDir and dataLogDir parameters at startup

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334327#comment-16334327 ] ASF GitHub Bot commented on ZOOKEEPER-2967: --- Github user anmolnar commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2967) Add check to validate dataDir and dataLogDir parameters at startup

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334330#comment-16334330 ] ASF GitHub Bot commented on ZOOKEEPER-2967: --- Github user anmolnar commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2967) Add check to validate dataDir and dataLogDir parameters at startup

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334338#comment-16334338 ] ASF GitHub Bot commented on ZOOKEEPER-2967: --- Github user anmolnar commented on a diff in the

[GitHub] zookeeper pull request #450: ZOOKEEPER-2967: Add check to validate dataDir a...

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/450#discussion_r162946062 --- Diff: src/java/test/org/apache/zookeeper/server/persistence/FileTxnSnapLogTest.java --- @@ -159,4 +159,222 @@ public void onTxnLoaded(TxnHeader

[GitHub] zookeeper pull request #450: ZOOKEEPER-2967: Add check to validate dataDir a...

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/450#discussion_r162947080 --- Diff: src/java/test/org/apache/zookeeper/server/persistence/FileTxnSnapLogTest.java --- @@ -159,4 +159,222 @@ public void onTxnLoaded(TxnHeader

[GitHub] zookeeper pull request #450: ZOOKEEPER-2967: Add check to validate dataDir a...

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/450#discussion_r162929129 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java --- @@ -136,13 +136,51 @@ public FileTxnSnapLog(File dataDir, File

[GitHub] zookeeper pull request #450: ZOOKEEPER-2967: Add check to validate dataDir a...

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/450#discussion_r162945589 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/Util.java --- @@ -294,5 +297,25 @@ public int compare(File o1, File o2) {

[GitHub] zookeeper pull request #450: ZOOKEEPER-2967: Add check to validate dataDir a...

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/450#discussion_r162945403 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/Util.java --- @@ -83,7 +86,7 @@ public static URI makeFileLoggerURL(File dataDir, File

[GitHub] zookeeper pull request #450: ZOOKEEPER-2967: Add check to validate dataDir a...

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/450#discussion_r162946298 --- Diff: src/java/test/org/apache/zookeeper/server/persistence/FileTxnSnapLogTest.java --- @@ -159,4 +159,222 @@ public void onTxnLoaded(TxnHeader

[GitHub] zookeeper pull request #450: ZOOKEEPER-2967: Add check to validate dataDir a...

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/450#discussion_r162945532 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/Util.java --- @@ -294,5 +297,25 @@ public int compare(File o1, File o2) {

[GitHub] zookeeper pull request #450: ZOOKEEPER-2967: Add check to validate dataDir a...

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/450#discussion_r162948359 --- Diff: src/java/test/org/apache/zookeeper/server/persistence/FileTxnSnapLogTest.java --- @@ -159,4 +159,222 @@ public void onTxnLoaded(TxnHeader

[GitHub] zookeeper pull request #450: ZOOKEEPER-2967: Add check to validate dataDir a...

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/450#discussion_r162947464 --- Diff: src/java/test/org/apache/zookeeper/server/persistence/FileTxnSnapLogTest.java --- @@ -159,4 +159,222 @@ public void onTxnLoaded(TxnHeader

[GitHub] zookeeper pull request #450: ZOOKEEPER-2967: Add check to validate dataDir a...

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/450#discussion_r162954011 --- Diff: src/java/test/org/apache/zookeeper/server/persistence/FileTxnSnapLogTest.java --- @@ -159,4 +159,222 @@ public void onTxnLoaded(TxnHeader

[GitHub] zookeeper pull request #450: ZOOKEEPER-2967: Add check to validate dataDir a...

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/450#discussion_r162929390 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java --- @@ -136,13 +136,51 @@ public FileTxnSnapLog(File dataDir, File

[GitHub] zookeeper pull request #450: ZOOKEEPER-2967: Add check to validate dataDir a...

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/450#discussion_r162946041 --- Diff: src/java/test/org/apache/zookeeper/server/persistence/FileTxnSnapLogTest.java --- @@ -159,4 +159,222 @@ public void onTxnLoaded(TxnHeader

ZooKeeper_branch35_jdk8 - Build # 818 - Failure

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/818/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 59.58 KB...] [junit] Running